Opened 13 months ago

Closed 11 months ago

Last modified 11 months ago

#27868 closed defect (fixed)

Fix special characters in translations

Reported by: traumschule Owned by: emmapeel
Priority: Medium Milestone:
Component: Community/Translations Version:
Severity: Normal Keywords:
Cc: ggus Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Porkepix and geb in #tor reported   being visible on the update page:
https://pix.toile-libre.org/?img=1537965999.png

I ran a script to check if this also happened to other branches of the translation repo:
for branch in $(git branch -a|grep remotes/origin|grep -v HEAD|cut -f1); do echo $(basename $branch); git checkout -q $branch; rgrep --exclude-dir=.git ' '; done|less

It was only found in tor-launcher-network-settings_completed.
Being on it should we look for other strings as well?

Child Tickets

Change History (5)

comment:1 Changed 13 months ago by traumschule

Status: newneeds_review

comment:2 Changed 13 months ago by traumschule

Status: needs_reviewneeds_revision

Found more:

tba-android_stringsdtd
bn/android_strings.dtd:<!ENTITY abouthome_about_sync3 "Set up Firefox Sync to access bookmarks, history and tabs from your other devices&amp;#x00A0;»">
bn/android_strings.dtd:<!ENTITY abouthome_about_apps3 "Get apps from the Firefox Marketplace and discover the best the Web has to offer&amp;#x00A0;»">
tba-android_stringsdtd_completed
ga/android_strings.dtd:<!ENTITY abouthome_about_sync3 "Úsáid Firefox Sync le teacht ar leabharmharcanna, stair bhrabhsála, agus cluaisíní ó ghléasanna eile&amp;#x00A0;»">
ga/android_strings.dtd:<!ENTITY abouthome_about_apps3 "Faigh aipeanna ó Mhargadh Firefox le teacht ar scoth an Ghréasáin&amp;#x00A0;»">
it/android_strings.dtd:<!ENTITY abouthome_about_sync3 "Imposta Firefox Sync per accedere a segnalibri, cronologia e schede dai tuoi altri dispositivi&amp;#x00A0;»">
it/android_strings.dtd:<!ENTITY abouthome_about_apps3 "Ottieni app dal Firefox Marketplace e scopri il meglio che la rete ha da offrire&amp;#x00A0;»">
pt_BR/android_strings.dtd:<!ENTITY abouthome_about_sync3 "Configure o Firefox Sync para acessar favoritos, histórico e guias de seus outros dispositivos&amp;#x00A0;»">
pt_BR/android_strings.dtd:<!ENTITY abouthome_about_apps3 "Obtenha aplicativos do Firefox Marketplace e descubra o melhor que a Web tem a oferecer&amp;#x00A0;»">
he/android_strings.dtd:<!ENTITY abouthome_about_sync3 "הגדר את סינכרון Firefox כדי להשיג גישה אל סימניות, היסטוריה ולשוניות ממכשירים אחרים שלך&amp;#x00A0;«">
he/android_strings.dtd:<!ENTITY abouthome_about_apps3 "קבל יישומים מחנות Firefox וגלה את הטוב ביותר שיש לרשת להציע&amp;#x00A0;«">
tr/android_strings.dtd:<!ENTITY abouthome_about_sync3 "Yer imlerinize, tarama geçmişinize ve kullandığınız sekmelere diğer aygıtlardan erişmek için Firefox Sync özelliğini ayarlayın&amp;#x00A0;»">
tr/android_strings.dtd:<!ENTITY abouthome_about_apps3 "Firefox Marketplace üzerinden uygulamalar alın ve olabilecek en iyi Web deneyimini yaşayın&amp;#x00A0;»">
tor-and-https
tor-and-https_completed
tor-browser-manual
tor-browser-manual_completed
tor-launcher-network-settings
ru/network-settings.dtd:<!ENTITY torsettings.bridgeHelp1 "Мосты - это незарегистрированные реле, которые затрудняют блокировку соединений с сетью Tor.&amp;#160 Каждый тип моста использует отличный от
 других метод, чтобы избежать блокировки цезорами. Обходные устройства делают ваш трафик похожим на случайный шум и имитируют то, что он подключается к этой службе вместо Tor.">
tor-launcher-network-settings_completed
hr_HR/network-settings.dtd:<!ENTITY torsettings.useBridges.note "Svaka vrsta mosta koristi drugačiju metodu kako bi izbjegla cenzuru.&amp;#160: Ako jedan most ne radi, probajte koristiti drugi.">
ru/network-settings.dtd:<!ENTITY torsettings.bridgeHelp1 "Мосты - это незарегистрированные реле, которые затрудняют блокировку соединений с сетью Tor.&amp;#160 Каждый тип моста использует отличный от
 других метод, чтобы избежать блокировки цезорами. Обходные устройства делают ваш трафик похожим на случайный шум и имитируют то, что он подключается к этой службе вместо Tor.">

comment:3 Changed 13 months ago by traumschule

Status: needs_revisionneeds_review

Probably only _completed is interesting otherwise there's more in https://github.com/traumschule/tor-translation/branches

https://github.com/traumschule/tor-translation/tree/tba-android_stringsdtd_completed
https://github.com/traumschule/tor-translation/tree/tor-launcher-network-settings_completed

tsum had a lot &amp;quot; and i decided not to fix them manually:
for file in $(rgrep -l '\&amp;quot;' --exclude-dir=.git) ; do cat $file | sed -E 's/&amp;quot;/\&quot;/g' > temp && mv temp $file && echo $file ; done
https://github.com/traumschule/tor-translation/tree/tsum_completed

Also found &amp;formatD; and &amp;brandShortName; in android_strings.dtd and aboutdialog.dtd but i guess these are no errors.

That was fun!

comment:4 Changed 13 months ago by emmapeel

Thanks for working on this!

Probably only _completed is interesting

Well, not really: the problem will stay in Transifex if we dont fix it, and when the translation is completed is going to appear in the _completed branches as well. I think it is better to search for this problems in Transifex, and add also a comment in the sourcecode or in Transifex 'context' section about this.

comment:5 Changed 11 months ago by emmapeel

Resolution: fixed
Status: needs_reviewclosed

ok, the translations in tor-launcher-network-settings_completed were not completed anymore but were still there because they were completed once. That needs to be fixed too, but is #26878

the nice little script gives no more bad results now, so i close this one.

thanks!

Last edited 11 months ago by emmapeel (previous) (diff)
Note: See TracTickets for help on using tickets.