Opened 7 months ago

Last modified 6 months ago

#27878 needs_review enhancement

docs/en/update_signing-keys.pl should not use default ~/.gnupg

Reported by: boklm Owned by: traumschule
Priority: Medium Milestone:
Component: Webpages/Website Version:
Severity: Normal Keywords:
Cc: traumschule Actual Points:
Parent ID: #22637 Points:
Reviewer: Sponsor:

Description

The script docs/en/update_signing-keys.pl is updating keys in the default gpg keyring.

Instead I think it should create a temporary one, creating a temporary directory and using the --homedir option.

Child Tickets

Change History (6)

comment:1 Changed 7 months ago by traumschule

Status: assignedneeds_review

comment:2 in reply to:  1 Changed 7 months ago by boklm

Status: needs_reviewneeds_revision

Replying to traumschule:

You are right, fixed in: https://github.com/torproject/webwml/pull/56

Maybe you can create the directory with tempdir from File::Temp, with CLEANUP => 1 so it is removed automatically at the end.

Also it seems you did not update the gpg --recv-key line.

comment:3 Changed 7 months ago by traumschule

Status: needs_revisionneeds_review
Last edited 7 months ago by traumschule (previous) (diff)

comment:4 in reply to:  3 Changed 7 months ago by boklm

Status: needs_reviewneeds_revision

Replying to traumschule:

Thanks, makes it much cleaner.
https://github.com/torproject/webwml/pull/56/files
edit: the CLEANUP bit is default

CLEANUP is the default in the object interface, but not with the tempdir function.

comment:5 Changed 7 months ago by traumschule

Status: needs_revisionneeds_review

changed and pushed.

comment:6 Changed 6 months ago by traumschule

does this look ok now?

Note: See TracTickets for help on using tickets.