many occurrences of "Firefox" in about:preferences

added TorBrowserTeam201810R component::applications/tor browser ff60-esr owner::mcs priority::medium resolution::fixed severity::normal status::closed tbb-8.0-issues tbb-branding type::defect labels

Here is a patch: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug27905-01&id=f8bdd93d75fb9d74ffacf4b0524c50a9026ceb95

For some reason Mozilla made it possible for the brand short name to be localized, and in fact the ESR60 language packs include a brand.ftl file (all of which probably have -brand-short-name = Firefox, so what's the point?) We worked around this problem by adding a tor-browser-brand.ftl file which is used instead of brand.ftl.

Note that there are two items with about:preferences that are not fixed by this patch:

There is an occurrence of Firefox within the Change Block List "dialog" which is not easily fixed because it is hard-coded within a localizable string. This was fixed in Firefox 61 but may not be easy to backport; see https://hg.mozilla.org/mozilla-central/rev/8ebf84e9825d
The Data Collection and Use" section also includes some hard-coded occurrences of Firefox`. But I think we should hide that section anyway; see #27909 (moved).

Trac:
Keywords: TorBrowserTeam201809 deleted, TorBrowserTeam201809R added
Status: assigned to needs_review

Moving review tickets to October

Trac:
Keywords: TorBrowserTeam201809R deleted, TorBrowserTeam201810R added

Replying to mcs:

Here is a patch: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug27905-01&id=f8bdd93d75fb9d74ffacf4b0524c50a9026ceb95

For some reason Mozilla made it possible for the brand short name to be localized, and in fact the ESR60 language packs include a brand.ftl file (all of which probably have -brand-short-name = Firefox, so what's the point?) We worked around this problem by adding a tor-browser-brand.ftl file which is used instead of brand.ftl.

Note that there are two items with about:preferences that are not fixed by this patch:

There is an occurrence of Firefox within the Change Block List "dialog" which is not easily fixed because it is hard-coded within a localizable string. This was fixed in Firefox 61 but may not be easy to backport; see https://hg.mozilla.org/mozilla-central/rev/8ebf84e9825d

Could you file a ticket for that so we have it on our ff68-esr radar (I agree, the backport effort might not be worth it in this case)

The Data Collection and Use" section also includes some hard-coded occurrences of Firefox`. But I think we should hide that section anyway; see #27909 (moved).

Sounds good.

The patch looks good to me. I cherry-picked it to tor-browser-60.2.1esr-8.5-1 (commit 482dd99c9507ae456578ba1fedfb4cc714e87ecc). Marking it for a possible backport.

Trac:
Resolution: N/A to fixed
Keywords: N/A deleted, tbb-backport added
Status: needs_review to closed