Opened 10 months ago

Closed 9 months ago

Last modified 3 months ago

#27905 closed defect (fixed)

many occurrences of "Firefox" in about:preferences

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-8.0-issues, TorBrowserTeam201810R
Cc: tbb-team, siketa Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are many occurrences of Firefox within about:preferences.

Child Tickets

Change History (7)

comment:1 Changed 10 months ago by mcs

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201809 removed
Status: assignedneeds_review

Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug27905-01&id=f8bdd93d75fb9d74ffacf4b0524c50a9026ceb95

For some reason Mozilla made it possible for the brand short name to be localized, and in fact the ESR60 language packs include a brand.ftl file (all of which probably have -brand-short-name = Firefox, so what's the point?) We worked around this problem by adding a tor-browser-brand.ftl file which is used instead of brand.ftl.

Note that there are two items with about:preferences that are not fixed by this patch:

  1. There is an occurrence of Firefox within the Change Block List "dialog" which is not easily fixed because it is hard-coded within a localizable string. This was fixed in Firefox 61 but may not be easy to backport; see https://hg.mozilla.org/mozilla-central/rev/8ebf84e9825d
  2. The Data Collection and Use" section also includes some hard-coded occurrences of Firefox`. But I think we should hide that section anyway; see #27909.

comment:2 Changed 10 months ago by gk

Keywords: TorBrowserTeam201810R added; TorBrowserTeam201809R removed

Moving review tickets to October

comment:3 in reply to:  1 ; Changed 9 months ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug27905-01&id=f8bdd93d75fb9d74ffacf4b0524c50a9026ceb95

For some reason Mozilla made it possible for the brand short name to be localized, and in fact the ESR60 language packs include a brand.ftl file (all of which probably have -brand-short-name = Firefox, so what's the point?) We worked around this problem by adding a tor-browser-brand.ftl file which is used instead of brand.ftl.

Note that there are two items with about:preferences that are not fixed by this patch:

  1. There is an occurrence of Firefox within the Change Block List "dialog" which is not easily fixed because it is hard-coded within a localizable string. This was fixed in Firefox 61 but may not be easy to backport; see https://hg.mozilla.org/mozilla-central/rev/8ebf84e9825d

Could you file a ticket for that so we have it on our ff68-esr radar (I agree, the backport effort might not be worth it in this case)

  1. The Data Collection and Use" section also includes some hard-coded occurrences of Firefox`. But I think we should hide that section anyway; see #27909.

Sounds good.

The patch looks good to me. I cherry-picked it to tor-browser-60.2.1esr-8.5-1 (commit 482dd99c9507ae456578ba1fedfb4cc714e87ecc). Marking it for a possible backport.

comment:4 in reply to:  3 Changed 9 months ago by mcs

Replying to gk:

Could you file a ticket for that so we have it on our ff68-esr radar (I agree, the backport effort might not be worth it in this case)

Done; see #27989.

comment:5 Changed 9 months ago by gk

Note for backporting we likely need to have #28196 fixed as well.

comment:6 Changed 6 months ago by gk

Cc: siketa added

Resolved #28959 as duplicate.

comment:7 Changed 3 months ago by gk

Keywords: tbb-backport removed

We don't plan any 8.0.x builds anymore, thus nothing to backport for that series.

Note: See TracTickets for help on using tickets.