#27919 closed enhancement (fixed)

Backport SSL status API to Tor Browser alpha

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201812R, GeorgKoppen201811
Cc: pastly, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We'd like to test selfauthenticating subdomains in nightly/alpha releases. We need to backport the WebExtensions SSL status API for that. This includes patches for

https://bugzilla.mozilla.org/show_bug.cgi?id=1322748 and child bugs.

Child Tickets

Attachments (1)

toy-secinfo-webext.tgz (349.9 KB) - added by pastly 11 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 months ago by gk

Keywords: TorBrowserTeam201810 added

comment:2 Changed 11 months ago by gk

Keywords: TorBrowserTeam201811 added; TorBrowserTeam201810 removed

Moving our tickets to November.

comment:3 Changed 11 months ago by gk

Keywords: GeorgKoppen201811 added

comment:4 Changed 11 months ago by pastly

Cc: pastly added

comment:5 Changed 11 months ago by gk

Status: newneeds_information

pastly: I have a potential backport in my bug_27919 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_27919). What would be a good way to test that one, to make sure it is actually doing what you need?

comment:6 Changed 11 months ago by pastly

I will make a little toy extension that expects the API to exist and logs the securityInfo to the browser debug console.

Changed 11 months ago by pastly

Attachment: toy-secinfo-webext.tgz added

comment:7 Changed 11 months ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201812R added; TorBrowserTeam201811 removed
Status: needs_informationneeds_review

Okay, this works with bug_27919_v3 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_27919_v3) (last six commits authored by Shane Caraveo). I backported the patch for the main bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1322748) and all the child bugs that we need. Please review.

comment:8 Changed 11 months ago by mcs

r=brade, r=mcs
Kathy and I checked the dependencies and we think you got them all. We also checked the accuracy of the backported patches and everything looks good to us.

comment:9 Changed 11 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Merged to tor-browser-60.3.0esr-8.5-1 (commits c1774ae7fc74bef7956caca4fe1b8de1365f5d48, 1935dcf38ca112f9fbc9fe42c2289d77e4f95932, 1305066f21439675842aad91844e6b490df8c3e0, 05cbc6e53b30707e32af750eb082a90f715cbf95, b81fe53f5fe1ecd749ca900ccfc1a00ae1fd9328, and b3d74f7db1cc0ddf54771e3e9e5de4b8549b0c88).

This will be available in 8.5a6, if nothing explodes.

Note: See TracTickets for help on using tickets.