Opened 8 months ago

Closed 6 months ago

Last modified 5 months ago

#27929 closed defect (implemented)

Consider no longer calling routerlist_remove_old_routers() from check_descriptor_callback()

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor: Sponsor8-can

Description

2237     /* Remove dead routers. */
2238     /* XXXX This doesn't belong here, but it was here in the pre-
2239      * XXXX refactoring code. */
2240     routerlist_remove_old_routers();
2241   }

We should see if there's better place to call this function from.

Child Tickets

Change History (9)

comment:1 Changed 7 months ago by teor

Keywords: technical-debt added

comment:2 Changed 7 months ago by rl1987

Status: newneeds_review

comment:3 Changed 7 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.0.x-final

comment:4 Changed 6 months ago by asn

Reviewer: nickm

comment:5 Changed 6 months ago by nickm

Status: needs_reviewneeds_revision

Added a few questions and comments. Rl1987, what do you think? I am genuinely unsure on most of these points.

comment:6 Changed 6 months ago by rl1987

Status: needs_revisionneeds_review

comment:7 Changed 6 months ago by nickm

Status: needs_reviewmerge_ready

okay, this seems reasonable to me now. It won't hurt anything to leave it as a named callback.

I'm going to hold off merging this until #28335 is in, though, since I expect a conflict.

comment:8 Changed 6 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged, and the conflict was only small. Resolved it with fc1ad9ab652063bdabb56a71ea6c005b66ed9f4c. Please let me know if I messed up there.

comment:9 Changed 5 months ago by nickm

Sponsor: Sponsor8-can
Note: See TracTickets for help on using tickets.