Chutney's owning controller process code compares strings with ints

Chutney's owning controller process code compares an environmental variable with an int, without converting the string to an int.

added actualpoints::0.1 component::core tor/chutney fast-fix owner::teor points::0.1 priority::medium resolution::fixed reviewer::nickm severity::normal sponsor::19 status::closed type::defect labels

Reported by Steven Engler, who pointed us to these lines: https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L877-L879

Trac:
Milestone: N/A to Tor: unspecified

Trac:
Milestone: Tor: unspecified to N/A

Would you be okay with a patch that moves these lines out of the TorNet.py file and into the test-network.sh script? It would make more sense to me to keep these out of TorNet.py since these three environment variables don't seem relevant to Chutney as a whole, but more just for the test network script.

On the other hand there may be reasons why they were put in TorNet.py, and in that case, I can submit a patch which fixes the problem directly (wraps the os.environ.get() in an int() call).

Replying to opara:

Would you be okay with a patch that moves these lines out of the TorNet.py file and into the test-network.sh script? It would make more sense to me to keep these out of TorNet.py since these three environment variables don't seem relevant to Chutney as a whole, but more just for the test network script.

On the other hand there may be reasons why they were put in TorNet.py, and in that case, I can submit a patch which fixes the problem directly (wraps the os.environ.get() in an int() call).

When CHUTNEY_CONTROLLING_PID is set, chutney sets the __OwningControllerProcess torrc option, so that tor exits when chutney is finished. But when any of these environmental variable are negative numbers, the user wants tor to keep running after chutney exits, so we don't set __OwningControllerProcess.

So we need to patch TorNet.py to cast the strings to ints.

Edit: typo

Trac:
Component: Core Tor/Tor to Core Tor/Chutney

opara, did you still want to write this patch?

Trac:
Keywords: N/A deleted, fast-fix added

We need this bug fixed to test PTs and other chutney tests.

Here's a pull request: https://github.com/torproject/chutney/pull/15

Trac:
Actualpoints: N/A to 0.1
Reviewer: N/A to nickm
Sponsor: N/A to Sponsor19
Points: N/A to 0.1

LGTM, and tests pass. Feel free to merge!

Trac:
Status: assigned to merge_ready

Merged to master as ce93bf0

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/core/chutney#27947 (closed)