Opened 13 months ago

Closed 13 months ago

Last modified 12 months ago

#27952 closed defect (worksforme)

Using undo in the search reveals previous queries and sites visited

Reported by: anadahz Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team
Cc: antonela Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by anadahz)

Tor Browser version: 8.5a2 (based on Mozilla Firefox 60.2.0esr) (64-bit)

Undo reveals all previous queries and URLs previously entered from all open or closed tabs in the current session.

Is this an expected behavior?

Child Tickets

Change History (7)

comment:1 Changed 13 months ago by anadahz

Description: modified (diff)

comment:2 Changed 13 months ago by gk

Status: newneeds_information

Do you have some steps to reproduce this bug report? I just entered "test" in the comment textbox and did a Ctrl+Z (aka Undo) but nothing happened. How can I see your issue. In general, though, as long as you are in the same session and did not request a "New Identity" I think this is not unexpected.

comment:3 Changed 13 months ago by anadahz

Do you have some steps to reproduce this bug report? I just entered "test" in the comment textbox and did a Ctrl+Z (aka Undo) but nothing happened. How can I see your issue.

  1. Press Ctrl+l, type test and press enter (by default this should query the default search engine for the string test)
  2. Press Ctrl+l, type test2 and press enter
  3. Press Ctrl+l, type test3 and press enter
  4. Press Ctrl+l and Ctrl+z (only) consecutive times to reveal the previous searched queries: test, test2 and test3.

In general, though, as long as you are in the same session and did not request a "New Identity" I think this is not unexpected.

That is what I also thought that is an expected behavior, ideally it will be good to have a "always forget my previous history during an active session" config option.

comment:4 in reply to:  3 Changed 13 months ago by gk

Resolution: worksforme
Status: needs_informationclosed

Replying to anadahz:

Do you have some steps to reproduce this bug report? I just entered "test" in the comment textbox and did a Ctrl+Z (aka Undo) but nothing happened. How can I see your issue.

  1. Press Ctrl+l, type test and press enter (by default this should query the default search engine for the string test)
  2. Press Ctrl+l, type test2 and press enter
  3. Press Ctrl+l, type test3 and press enter
  4. Press Ctrl+l and Ctrl+z (only) consecutive times to reveal the previous searched queries: test, test2 and test3.

In general, though, as long as you are in the same session and did not request a "New Identity" I think this is not unexpected.

That is what I also thought that is an expected behavior, ideally it will be good to have a "always forget my previous history during an active session" config option.

I am not sure why that would be good as long as web content does not have access to the history (which is does not have AFAICT). So, I think this works for us right now.

comment:5 Changed 13 months ago by anadahz

I am not sure why that would be good as long as web content does not have access to the history (which is does not have AFAICT). So, I think this works for us right now.

If we are sure that web content cannot retrieve history from the location bar (and recently closed tabs) then this should be closed.

Preferably it will be good for Tor Browser users to be aware that all the text entered in the location bar (such as queries to search engines, URLs, mis-pasted text from their clipboard) remains until a new identity is requested or a browser quit.

comment:6 Changed 13 months ago by pili

Cc: antonela added

Maybe his could be a good "educational moment" from a UX perspective?

comment:7 Changed 12 months ago by antonela

Keywords: ux-team added

New Identity request should make clear that those data get deleted. I added this ticket to the bucket list for New Identity work.

Note: See TracTickets for help on using tickets.