Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#28006 closed defect (implemented)

shellcheck: chutney-git-bisect.sh issues

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: mikeperry Sponsor:

Description

Shellcheck (https://github.com/koalaman/shellcheck) finds the following issues:

In chutney-git-bisect.sh line 23:
    cd "$2"
    ^-- SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.


In chutney-git-bisect.sh line 57:
    i=$[$i+1]
      ^-- SC2007: Use $((..)) instead of deprecated $[..]


In chutney-git-bisect.sh line 60:
i=$[$i-1]
  ^-- SC2007: Use $((..)) instead of deprecated $[..]

Child Tickets

Change History (9)

comment:1 Changed 8 months ago by rl1987

Status: newneeds_review

comment:2 Changed 7 months ago by dgoulet

Reviewer: teor

comment:3 Changed 7 months ago by dgoulet

Reviewer: teormikeperry

comment:4 Changed 7 months ago by teor

Component: Core Tor/TorCore Tor/Chutney

comment:5 Changed 7 months ago by teor

Component: Core Tor/ChutneyCore Tor/Tor

Oops, this is a tor ticket.

comment:6 Changed 7 months ago by mikeperry

Status: needs_reviewmerge_ready

Looks good.

comment:7 Changed 7 months ago by nickm

Milestone: Tor: 0.3.6.x-final

comment:8 Changed 7 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

comment:9 Changed 7 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

Note: See TracTickets for help on using tickets.