Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#28010 closed defect (fixed)

shellcheck: issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: mikeperry Sponsor:


Shellcheck (​​​​ finds the following issues:

In line 12:
for file in `find ./src/trunnel/ -name '*.trunnel'`; do
            ^-- SC2044: For loops over find output are fragile. Use find -exec or a while read loop.
            ^-- SC2006: Use $(..) instead of legacy `..`.

In line 13:
  python -m trunnel ${OPTIONS} $file
                               ^-- SC2086: Double quote to prevent globbing and word splitting.

Child Tickets

Change History (7)

comment:1 Changed 2 years ago by teor

Keywords: technical-debt added
Milestone: Tor: 0.3.6.x-final

Since these tickets are about technical debt, I'm tentatively putting them in 0.3.6.

To avoid issues like this in future, we could run shellcheck as part of "make check" (#28058).

comment:2 Changed 2 years ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:3 Changed 2 years ago by rl1987

Status: acceptedneeds_review

comment:4 Changed 2 years ago by dgoulet

Reviewer: mikeperry

comment:5 Changed 2 years ago by mikeperry

Status: needs_reviewmerge_ready

Looks good!

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed


comment:7 Changed 2 years ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

Note: See TracTickets for help on using tickets.