Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#28011 closed defect (fixed)

shellcheck: run_calltool.sh issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: mikeperry Sponsor:

Description

Shellcheck (​​​​​https://github.com/koalaman/shellcheck) finds the following issues:

In run_calltool.sh line 18:
  python -m calltool $calculation > callgraph/$calculation
                     ^-- SC2086: Double quote to prevent globbing and word splitting.
                                              ^-- SC2086: Double quote to prevent globbing and word splitting.


In run_calltool.sh line 21:
echo <<EOF > callgraph/README
^-- SC2217: Redirecting to 'echo', a command that doesn't read stdin. Bad quoting or missing xargs?

Child Tickets

Change History (7)

comment:1 Changed 10 months ago by teor

Keywords: technical-debt added
Milestone: Tor: 0.3.6.x-final

Since these tickets are about technical debt, I'm tentatively putting them in 0.3.6.

To avoid issues like this in future, we could run shellcheck as part of "make check" (#28058).

comment:2 Changed 10 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:3 Changed 10 months ago by rl1987

Status: acceptedneeds_review

comment:4 Changed 10 months ago by dgoulet

Reviewer: mikeperry

comment:5 Changed 10 months ago by mikeperry

Status: needs_reviewmerge_ready

Looks good!

comment:6 Changed 10 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

comment:7 Changed 10 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

Note: See TracTickets for help on using tickets.