#28022 closed defect (fixed)

Use "/usr/bin/env bash" instead of "/bin/bash" in Browser/execdesktop

Reported by: readingflower Owned by: tbb-team
Priority: Very Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Trivial Keywords: GeorgKoppen201810, TorBrowserTeam201810R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Some Linux distributions (like mine) don't use the "standard/debian application paths". Normally "/usr/bin/env ${app}" does the trick on most obscure systems.

So changing the interpreter in Browser/execdesktop from "/bin/bash" to "/usr/bin/env bash" would be the solution.

Child Tickets

Change History (2)

comment:1 Changed 10 months ago by gk

Keywords: GeorgKoppen201810 TorBrowserTeam201810R added; linux bash interpreter removed
Status: newneeds_review

Seems this is okay as we do already use /usr/bin/env in related scripts. bug_28022 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28022&id=efa753da88f7c71a8bf7a1b3c09e629bd1278d14) has a patch.

comment:2 Changed 10 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I cherry-picked this to master as commit c65b5af3d9c565d4e274fbd8606f0404623a19e1.

Note: See TracTickets for help on using tickets.