Opened 2 months ago

Closed 5 weeks ago

#28039 closed defect (fixed)

Tor Browser log is not shown anymore in terminal since Tor Browser 8.5a2

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-regression, GeorgKoppen201810, TorBrowserTeam201811R
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Starting with Tor Browser 8.5a2 no log is shown anymore in the terminal on Linux.

STR:

1) Start Tor Browser with ./start-tor-browser.desktop --debug
2) Open about:config and set extensions.torbutton.loglevel to 3 and extensions.torbutton.logmethod to 0
3) Go to torproject.org

Expected: See circuit building related output in terminal
Actual: No log messages show up.

Child Tickets

Change History (9)

comment:1 Changed 2 months ago by gk

I used a 8.5a1 and replaced the Torbutton and tor version with the ones we ship in 8.5a2, nothing changes.

comment:2 Changed 8 weeks ago by gk

Keywords: GeorgKoppen201810 added

comment:3 Changed 8 weeks ago by gk

Cc: mcs brade added

The problem is the fix for #27623. More specifically, browser.dom.window.dump.enabled is now the preference that is relevant here: while logging was still possible in Tor Browser 7.x with it set to false this is not the case anymore in Firefox based on ESR 60 it seems. And MOZILLA_OFFICIAL toggles it.

I wonder whether we should follow Mozilla here and add an extra step to get logging going. But on the other hand if I start Tor Browser with --log I expect that it does what it promises and logs. Not doing so, or needing to do yet another thing to get that going sounds like a bug.

So, should we enable browser.dom.window.dump.enabled for macOS and Linux then?

comment:4 in reply to:  3 Changed 8 weeks ago by mcs

Replying to gk:

So, should we enable browser.dom.window.dump.enabled for macOS and Linux then?

I say yes, or just enable it for all platforms, e.g., by setting browser.dom.window.dump.enabled to true in 000-tor-browser.js.

For reference:
"dump() in JS Components should obey browser.dom.window.dump.enabled"
https://bugzilla.mozilla.org/show_bug.cgi?id=379797

"Enable dump() by default in local builds"
https://bugzilla.mozilla.org/show_bug.cgi?id=1395711

comment:5 Changed 8 weeks ago by gk

I think I have a better plan: We enable browser.dom.window.dump.enabled in case one of Torbutton's/Tor Launcher's logmethod prefs gets set to 0 and disable it if both of them are non-0 (which is Tor Browser's default state).

comment:6 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201810R added; TorBrowserTeam201810 removed
Status: newneeds_review

comment:7 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201810R removed

Moving reviews to November.

comment:8 Changed 5 weeks ago by mcs

r=brade, r=mcs
One tiny nit: the second backtick character in the Tor Launcher commit message is slightly misplaced, i.e., the first line should be:

Without setting browser.dom.window.dump.enabled explicitly to true

(transpose the ` and space after the pref name).

comment:9 Changed 5 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. I fixed the backtick issue and pushed both commits to their respective master branches (commit 80749f18beb93f94cb6be9a5e2c17438ff133ab8 for tor-launcher and commit 923fd8500a16b0a343450621a62ea10175c38b3d for `torbutton).

Note: See TracTickets for help on using tickets.