Opened 9 months ago

Closed 9 months ago

Last modified 8 months ago

#28062 closed defect (implemented)

Publish bandwidth files only when they contain only the 60% of relays

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: sbws-1.0-nice-closed-moved-20181128
Cc: pastly, juga, teor Actual Points:
Parent ID: #28042 Points:
Reviewer: Sponsor:

Description

When running sbws in the way it behaves as Torflow.
As commented in https://trac.torproject.org/projects/tor/ticket/28042#comment:2

Child Tickets

Change History (9)

comment:1 Changed 9 months ago by pastly

This seems reasonable and straightforward to implement in generate.py. No further opinion here at this time.

comment:2 Changed 9 months ago by juga

Status: assignedneeds_review

https://github.com/torproject/sbws/pull/274

Implemented removing link, see comment #28042#comment:4

comment:3 Changed 9 months ago by teor

Status: needs_reviewmerge_ready

This code looks good to me. I think we should merge it.

We could also publish our progress in the bandwidth file header, and not put any relays in the file. See #28076 in sbws 1.1.

comment:4 Changed 9 months ago by teor

Status: merge_readyneeds_revision

Based on the comments in #28042, I think we need to implement #28076, where we create a file with a header but no relays.

comment:5 in reply to:  4 Changed 9 months ago by juga

Replying to teor:

Based on the comments in #28042, I think we need to implement #28076, where we create a file with a header but no relays.

I can add an option to either remove the file or add the header.
Would you prefer i then close this ticket and add all of this in #28076 or merge this and then change it in 28076?

comment:6 Changed 9 months ago by juga

Status: needs_revisionneeds_review

I implemented #28076 based on the PR here. If #28076 is accepted, this can be removed

comment:7 Changed 9 months ago by juga

s/removed/closed/

comment:8 Changed 9 months ago by juga

Resolution: implemented
Status: needs_reviewclosed

Merged in #28076

comment:9 Changed 8 months ago by teor

Keywords: sbws-1.0-nice-closed-moved-20181128 added
Milestone: sbws 1.0 (MVP nice)sbws: 1.0.x-final

Move all closed sbws 1.0 nice tickets to sbws 1.0.x-final

Note: See TracTickets for help on using tickets.