Opened 6 months ago

Closed 5 months ago

#28075 closed defect (fixed)

Torbutton WARN: no SOCKS credentials found for current document.

Reported by: traumschule Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, GeorgKoppen201810, TorBrowserTeam201812R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This warning appears in the log quite often. It might be benign and can probably be downgraded to INFO or DEBUG.

Torbutton WARN: no SOCKS credentials found for current document.

I can trigger this message setting app.update.log to true in about:config and opening the noscript settings.

found this also in #27828, #27221, #26579, #25946, #24654, #24263, #20195, #18138

Another message that appears on moz-extension://ff54e967-998f-4b5d-84b4-1aedfa73532d/ui/options.html:

JavaScript error: moz-extension://ff54e967-998f-4b5d-84b4-1aedfa73532d/lib/Messages.js, line 0: Error: Message broadcastSettings {"tabId":-1,"meta":{"name":"broadcastSettings","recipientInfo":null},"_messageName":"broadcastSettings"} looping to its sender (moz-extension://ff54e967-998f-4b5d-84b4-1aedfa73532d/ui/options.html#;tab-main-tabs=3)

(can't remember to have seen this before so it could have been introduced in Noscript 10.1.9.9)

Child Tickets

Change History (6)

comment:1 Changed 6 months ago by gk

Component: Applications/TorbuttonApplications/Tor Browser
Keywords: tbb-torbutton added
Owner: set to tbb-team

comment:2 Changed 6 months ago by gk

Keywords: GeorgKoppen201810 TorBrowserTeam201810R added
Status: newneeds_review

I think WARN is indeed too much. This is related to the circuit display and in case there is no node data available this log line is emitted. I think we want to keep this captured by the default log level (NOTE), though, to spot potential issues easier. Thus, I'd just tone it down to NOTE for now. bug_28075 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_28075&id=ff6624e0efb741f53fe250a283e983fbbd0dfc66) does that.

comment:3 Changed 6 months ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201810R removed

Moving reviews to November.

comment:4 Changed 5 months ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201811R removed

Move review tickets to Decemeber.

comment:5 Changed 5 months ago by mcs

r=brade, r=mcs
The patch looks good and the change seems like a good one.

comment:6 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks! Cherry-picked to master (commit 0b60f61087b514f74ea21513f14e691c2bd30493).

Note: See TracTickets for help on using tickets.