Opened 12 months ago

Closed 12 months ago

Last modified 11 months ago

#28076 closed defect (implemented)

When sbws has measured less than 60% of relays, write a header with progress

Reported by: teor Owned by:
Priority: Medium Milestone: sbws: unspecified
Component: Core Tor/sbws Version:
Severity: Normal Keywords:
Cc: pastly, juga, teor Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by teor)

In #28062, we remove the link to the bandwidth file when fewer than 60% of relays are measured.

Instead, we could write a bandwidth file containing a header field with:

  • number of relays measured / target number of relays / total number of relays
  • percentage of relays measured / target percentage

Edit: the bandwidth file would not contain any relays - just the header

Child Tickets

Change History (9)

comment:1 Changed 12 months ago by teor

Description: modified (diff)

comment:2 Changed 12 months ago by juga

Status: newneeds_review

https://github.com/torproject/sbws/pull/277, includes #28062 + cli argument + what explained here

comment:3 Changed 12 months ago by teor

Status: needs_reviewneeds_revision

I reviewed the code on the pull request.
It looks good, but we need to update the changelog entry.
I don't think we need the rm-link option, but you can keep it if you want.

comment:4 Changed 12 months ago by juga

Status: needs_revisionmerge_ready

Revised, modified what was suggested by teor, except the warning when the minimum percent was reached before but not currently, since it implies bigger modifications.

comment:5 Changed 12 months ago by juga

Resolution: implemented
Status: merge_readyclosed

Merged

comment:6 Changed 11 months ago by teor

Milestone: sbws 1.1sbws 1.2

Milestone renamed

comment:7 Changed 11 months ago by teor

Milestone: sbws 1.2sbws: 1.2.x

Milestone renamed

comment:8 Changed 11 months ago by teor

Milestone: sbws: 1.2.xsbws: 1.2.x-final

Milestone renamed

comment:9 Changed 11 months ago by teor

Milestone: sbws: 1.2.x-finalsbws: unspecified

Milestone renamed

Note: See TracTickets for help on using tickets.