Opened 10 months ago

Closed 10 months ago

Last modified 9 months ago

#28082 closed defect (fixed)

Add 4 more Tor Browser locales

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201810R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by arthuredelstein)

The following locales are 100% translated:

cs
el
hu
ka

I would like to propose adding them for Tor Browser. (Omitting es-AR for now because it seems to be overwritten by es-ES.)

Child Tickets

Change History (9)

comment:1 Changed 10 months ago by arthuredelstein

Description: modified (diff)
Keywords: TorBrowserTeam201810R added
Status: newneeds_review
Summary: Add 5 more Tor Browser localesAdd 4 more Tor Browser locales

Here are my patches for review:

I tested all four of these locales manually and I didn't run into any browser errors. (Currently running a build to confirm.)

comment:2 Changed 10 months ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: needs_reviewclosed

Looks good to me, let's test it in the alpha. I guess we can think about backporting the patch later on.
Merged to tor-browser-build's master (commit d8ce7fca64a15cf9b71f7685ef2a8f36dae6a21a) torbutton's master (commit 38cc505106a37e704ce11a41d22b74cfde36449f), and tor-launcher's master (commit 3aa20983122b4aaed6ae77cfc5bdb48107aa33a4).

comment:3 Changed 10 months ago by gk

Keywords: TorBrowserTeam201810R tbb-backport removed
Resolution: fixed
Status: closedreopened

Okay, this is the second time I trusted that we actually ship bundles that are not broken and it seems I was wrong again. I hit the same issue as in #26458 both on Linux and Windows. I should do a better job next time. Meanwhile I reverted all patches (tor-browser-build commit 6803d9a8a4e7c851629cab47342a6579a60f64cd, torbutton commit 8f1ff9017e9f793156d1edce38dde8cfcf590b2b, tor-launcher commit 670882ad2936a906f3e2d84230714446e98a214c) and added a note on our blog post.

Last edited 10 months ago by gk (previous) (diff)

comment:4 in reply to:  3 Changed 10 months ago by arthuredelstein

Replying to gk:

Okay, this is the second time I trusted that we actually ship bundles that are not broken and it seems I was wrong again. I hit the same issue as in #26458 both on Linux and Windows. I should do a better job next time. Meanwhile I reverted all patches (tor-browser-build commit 6803d9a8a4e7c851629cab47342a6579a60f64cd, torbutton commit 8f1ff9017e9f793156d1edce38dde8cfcf590b2b, tor-launcher commit 670882ad2936a906f3e2d84230714446e98a214c) and added a note on our blog post.

It turns out that in the torbutton master branch, the commit adding those 4 new locales (patch c94a5589ffeabf71ea95c3c5c1a3396bdbe14da5) was merged *after* translations were last updated (patch 9e5c4406e6458ae65e5a8ebb60c11fdd8cb527ea). So the strings for those locales were never pulled down. (Missing strings causes Tor Browser to choke.) Sorry I didn't catch this in time!

comment:5 Changed 10 months ago by gk

Keywords: TorBrowserTeam201810R added
Status: reopenedneeds_review

comment:6 Changed 10 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Commit e0701803216baa74b4166c34a7b85e00f8e327af (on master in tor-browser-build), 30fee1c708e5e6cae9c41105847e4d95deec2f20 (on master in tor-launcher), and b9d1a5a7f2808f533d32ffab11ad7ddb566888ec (on master in torbutton) should finally have the changes. I updated the translations in Torbutton as well (commit a62f5e98572d2dd6bcc5d7310dfbb431bcd6fec7 and bff597351775e60648e37e3328e424176d41b712) to make sure we don't miss strings for those locales.

comment:7 Changed 9 months ago by emmapeel

the translators want to know:

when are then this new locales going to be in TBB (not alpha)?

comment:8 in reply to:  7 ; Changed 9 months ago by gk

Replying to emmapeel:

the translators want to know:

when are then this new locales going to be in TBB (not alpha)?

That's not decided yet, but I think it is not unreasonable letting this ride the train and shipping all the new locales to stable users with Tor Browser 8.5 (planned for around March 2019).

comment:9 in reply to:  8 Changed 9 months ago by emmapeel

Replying to gk:

That's not decided yet, but I think it is not unreasonable letting this ride the train and shipping all the new locales to stable users with Tor Browser 8.5 (planned for around March 2019).

Thanks! I have made a call for the translators to test the alphas so we spot any trouble before release.

Note: See TracTickets for help on using tickets.