2018 Tor Browser Android donation banner

In #23925 (moved) we are implementing a donation banner for the YE 2018 campaign. It would be great to have a donation banner for Tor Browser Android as well. We already have the text in https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/en/aboutTor.dtd#n30 getting translated.

added TBA-a2 TorBrowserTeam201811R component::applications/tor browser owner::tbb-team priority::very high resolution::fixed severity::normal status::closed tbb-fundraising tbb-mobile type::defect ux-team labels

Trac:
Cc: antonela, sstevenson, pili, GeKo, igt0, sysrqb to antonela, sstevenson, pili, gk, igt0, sysrqb
Keywords: N/A deleted, TorBrowserTeam201810, tbb-mobile added

Trac:

Trac:

Trac:

Trac:

Trac:

hi! I attached a mock for each tagline. Not sure if we are going to have the same behavior we have in desktop. Just in case, mocks are available.

https://marvelapp.com/a131e34/screen/49395797/handoff

It is great! how it should look on a tablet? Replying to antonela:

hi! I attached a mock for each tagline. Not sure if we are going to have the same behavior we have in desktop. Just in case, mocks are available.

https://marvelapp.com/a131e34/screen/49395797/handoff

here >>

7inch https://marvelapp.com/a131e34/screen/49574765

9inch https://marvelapp.com/a131e34/screen/49574766

Moving our tickets to November.

Trac:
Keywords: TorBrowserTeam201810 deleted, TorBrowserTeam201811 added

Trac:
Priority: Medium to Very High

Moving on TBA-a2 radar

Trac:
Keywords: N/A deleted, TBA-a2 added

** Bug 28093: Update donation banner style to make it fit in small screens** https://github.com/igortoliveira/torbutton/commit/28baa143f5307d828380db11eea110f55461f2b3

Trac:
Status: new to needs_review

There are still issues with it on my phone, see attachment. (The "Explore" for instance, not sure if we want to have a banner or just the text vertically).

Trac:
Status: needs_review to needs_revision

Trac:

There's already some CSS that translates the "Explore. Privately." content downwards when the banner is visible:

https://github.com/igortoliveira/torbutton/blob/28baa143f5307d828380db11eea110f55461f2b3/src/chrome/skin/aboutTor.css#L384

Maybe it could be translated even a little more for small screens?

I will talk with Antonela to make sure we do the right thing. Maybe we need to remove the circles in the footer.

Hi team! if we have the circles pattern fixed at the bottom then we can overlap the title with the banner. I mean, the banner will push the content down.

https://marvelapp.com/a131e34/screen/49395797

I thought about it in that way especially for small screen devices. Is ok? doable? let me know!

Updated the code making modification to fit screens smaller than 480px.

https://github.com/igortoliveira/torbutton/commit/6adb53fae28b0b5fd44218c0bfd28c2a73c7b1db

Trac:
Status: needs_revision to needs_review

Trac:
Keywords: TorBrowserTeam201811 deleted, TorBrowserTeam201811R added

Looks better now here. Applied to master (a41034ced7a6c0fe590320d9da61d15df1fef42f).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#28093 (closed)