Opened 8 weeks ago

Closed 3 weeks ago

#28093 closed defect (fixed)

2018 Tor Browser Android donation banner

Reported by: arthuredelstein Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-fundraising, ux-team, tbb-mobile, TorBrowserTeam201811R, TBA-a2
Cc: antonela, sstevenson, pili, gk, igt0, sysrqb Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #23925 we are implementing a donation banner for the YE 2018 campaign. It would be great to have a donation banner for Tor Browser Android as well. We already have the text in https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/en/aboutTor.dtd#n30 getting translated.

Child Tickets

Attachments (6)

TBA - YE - anonymity.png (133.5 KB) - added by antonela 7 weeks ago.
TBA - YE - freedom.png (131.8 KB) - added by antonela 7 weeks ago.
TBA - YE - human-rights.png (134.1 KB) - added by antonela 7 weeks ago.
TBA - YE - privacy.png (133.5 KB) - added by antonela 7 weeks ago.
TBA - YE - strong.png (130.6 KB) - added by antonela 7 weeks ago.
banner_galaxy_s5_mini.jpg (2.6 MB) - added by gk 4 weeks ago.

Change History (21)

comment:1 Changed 8 weeks ago by gk

Cc: gk added; GeKo removed
Keywords: TorBrowserTeam201810 tbb-mobile added

Changed 7 weeks ago by antonela

Attachment: TBA - YE - anonymity.png added

Changed 7 weeks ago by antonela

Attachment: TBA - YE - freedom.png added

Changed 7 weeks ago by antonela

Attachment: TBA - YE - human-rights.png added

Changed 7 weeks ago by antonela

Attachment: TBA - YE - privacy.png added

Changed 7 weeks ago by antonela

Attachment: TBA - YE - strong.png added

comment:2 Changed 7 weeks ago by antonela

hi! I attached a mock for each tagline. Not sure if we are going to have the same behavior we have in desktop. Just in case, mocks are available.

https://marvelapp.com/a131e34/screen/49395797/handoff

comment:3 in reply to:  2 Changed 7 weeks ago by igt0

It is great! how it should look on a tablet?
Replying to antonela:

hi! I attached a mock for each tagline. Not sure if we are going to have the same behavior we have in desktop. Just in case, mocks are available.

https://marvelapp.com/a131e34/screen/49395797/handoff

comment:5 Changed 5 weeks ago by gk

Keywords: TorBrowserTeam201811 added; TorBrowserTeam201810 removed

Moving our tickets to November.

comment:6 Changed 5 weeks ago by gk

Priority: MediumVery High

comment:7 Changed 5 weeks ago by gk

Keywords: TBA-a2 added

Moving on TBA-a2 radar

comment:8 Changed 4 weeks ago by igt0

Status: newneeds_review

Bug 28093: Update donation banner style to make it fit in small screens
https://github.com/igortoliveira/torbutton/commit/28baa143f5307d828380db11eea110f55461f2b3

comment:9 Changed 4 weeks ago by gk

Status: needs_reviewneeds_revision

There are still issues with it on my phone, see attachment. (The "Explore" for instance, not sure if we want to have a banner or just the text vertically).

Last edited 4 weeks ago by gk (previous) (diff)

Changed 4 weeks ago by gk

Attachment: banner_galaxy_s5_mini.jpg added

comment:10 Changed 4 weeks ago by arthuredelstein

There's already some CSS that translates the "Explore. Privately." content downwards when the banner is visible:

https://github.com/igortoliveira/torbutton/blob/28baa143f5307d828380db11eea110f55461f2b3/src/chrome/skin/aboutTor.css#L384

Maybe it could be translated even a little more for small screens?

comment:11 Changed 3 weeks ago by igt0

I will talk with Antonela to make sure we do the right thing. Maybe we need to remove the circles in the footer.

comment:12 Changed 3 weeks ago by antonela

Hi team! if we have the circles pattern fixed at the bottom then we can overlap the title with the banner. I mean, the banner will push the content down.

https://marvelapp.com/a131e34/screen/49395797

I thought about it in that way especially for small screen devices. Is ok? doable? let me know!

comment:13 Changed 3 weeks ago by igt0

Status: needs_revisionneeds_review

Updated the code making modification to fit screens smaller than 480px.

https://github.com/igortoliveira/torbutton/commit/6adb53fae28b0b5fd44218c0bfd28c2a73c7b1db

comment:14 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201811 removed

comment:15 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks better now here. Applied to master (a41034ced7a6c0fe590320d9da61d15df1fef42f).

Note: See TracTickets for help on using tickets.