For about:tor, use a Tor Browser icon in identity box

Right now, the Firefox icon is displayed in the identity box. We should fix this. Antonela proposed the following design: https://trac.torproject.org/projects/tor/attachment/ticket/27200/27200.png

added TorBrowserTeam201901 component::applications/tor browser owner::pospeselr parent::25702 priority::medium resolution::fixed severity::normal status::closed tbb-branding type::defect ux-team labels

Trac:

Trac:

Trac:

As suggested by mcs, I tried replacing the Firefox icon with our Tor Browser icon. (When we implement a new Tor Browser icon, we can replace this again.)

Here's my patch: https://github.com/arthuredelstein/tor-browser/commit/28111

Here are screenshots:

FWIW, this is actually #18058 (moved) which is tagged with tbb-branding.

Looking at #18058 (moved) it seems Mozilla previously used

browser/branding/official/content/identity-icons-brand.png browser/branding/official/content/identity-icons-brand@2x.png

and similar files. It seems we need the @2x.png for high resolution displays on macOS unless we resort to .svg files (see comment:5:ticket:27156). However, you are replacing the .svg icons just with .png ones. Thus, I guess that does not take care of those displays and would show the Tor Browser icon blurry.

Trac:
Status: new to needs_revision

Closed #18058 (moved) as a duplicate.

Trac:
Cc: N/A to mcs, brade

Replying to gk:

Thanks for pointing out the duplicate ticket.

Looking at #18058 (moved) it seems Mozilla previously used

browser/branding/official/content/identity-icons-brand.png browser/branding/official/content/identity-icons-brand@2x.png

and similar files. It seems we need the @2x.png for high resolution displays on macOS unless we resort to .svg files (see comment:5:ticket:27156). However, you are replacing the .svg icons just with .png ones. Thus, I guess that does not take care of those displays and would show the Tor Browser icon blurry.

The PNG file I used is 32x32 whereas the icon in that location is sized to 16x16. So I think these PNGs are effectively @2x already.

Trac:
Status: needs_revision to needs_review
Keywords: N/A deleted, TorBrowserTeam201810R added

Hm, I wonder why Mozilla used two differnt icons for that then if they just could have used a 32x32 one. What speaks against moving to .svg as Mozilla eventually did?

Replying to gk:

Hm, I wonder why Mozilla used two differnt icons for that then if they just could have used a 32x32 one.

I'm not sure. I guess in principle it's more performant to have the image already at the scale you need. Although it seems unlikely it's a bottleneck.

What speaks against moving to .svg as Mozilla eventually did?

Nothing, except I couldn't find an SVG version of the green globe icon. If anyone has a copy of it I will be glad to make a new patch using the SVG instead.

Moving reviews to November.

Trac:
Keywords: TorBrowserTeam201810R deleted, TorBrowserTeam201811R added

I can actually swap this out with an SVG with the new branding as part of #25702 (moved).

Trac:
Owner: tbb-team to pospeselr
Parent: N/A to #25702 (moved)
Description: Right now, the Firefox icon is displayed in the identity box. We should fix this. Antonela proposed the following design: https://trac.torproject.org/projects/tor/attachment/ticket/27200/27200.png

to

Right now, the Firefox icon is displayed in the identity box. We should fix this. Antonela proposed the following design: https://trac.torproject.org/projects/tor/attachment/ticket/27200/27200.png

Cc: mcs, brade to mcs, brade, arthuredelstein, tbb-team
Status: needs_review to assigned

Replying to pospeselr:

I can actually swap this out with an SVG with the new branding as part of #25702 (moved).

I was just about to propose that while thinking about this ticket over the weekend. :) Thanks!

Trac:
Keywords: TorBrowserTeam201811R deleted, TorBrowserTeam201811 added

Moving our tickets to December.

Trac:
Keywords: TorBrowserTeam201811 deleted, TorBrowserTeam201812 added

Moving tickets to Jan 2019.

Trac:
Keywords: TorBrowserTeam201812 deleted, TorBrowserTeam201901 added

That's fixed with commit 7f7a40f907f74a531642a5cb4982f2d762316d38 on tor-browser-60.4.0esr-8.5-1.

Trac:
Status: assigned to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#28111 (closed)