Opened 9 months ago

Closed 6 months ago

#28111 closed defect (fixed)

For about:tor, use a Tor Browser icon in identity box

Reported by: arthuredelstein Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, tbb-branding, TorBrowserTeam201901
Cc: mcs, brade, arthuredelstein, tbb-team Actual Points:
Parent ID: #25702 Points:
Reviewer: Sponsor:

Description (last modified by pospeselr)

Right now, the Firefox icon is displayed in the identity box. We should fix this. Antonela proposed the following design:
https://trac.torproject.org/projects/tor/attachment/ticket/27200/27200.png

Child Tickets

Attachments (3)

identity_box_dark_theme.png (53.5 KB) - added by arthuredelstein 9 months ago.
identity_box_default_theme.png (51.6 KB) - added by arthuredelstein 9 months ago.
identity_box_default_theme_doorhanger.png (63.1 KB) - added by arthuredelstein 9 months ago.

Download all attachments as: .zip

Change History (16)

Changed 9 months ago by arthuredelstein

Attachment: identity_box_dark_theme.png added

Changed 9 months ago by arthuredelstein

Changed 9 months ago by arthuredelstein

comment:1 Changed 9 months ago by arthuredelstein

As suggested by mcs, I tried replacing the Firefox icon with our Tor Browser icon. (When we implement a new Tor Browser icon, we can replace this again.)

Here's my patch: https://github.com/arthuredelstein/tor-browser/commit/28111

Here are screenshots:




comment:2 Changed 9 months ago by gk

FWIW, this is actually #18058 which is tagged with tbb-branding.

comment:3 Changed 9 months ago by gk

Status: newneeds_revision

Looking at #18058 it seems Mozilla previously used

browser/branding/official/content/identity-icons-brand.png
browser/branding/official/content/identity-icons-brand@2x.png

and similar files. It seems we need the @2x.png for high resolution displays on macOS unless we resort to .svg files (see comment:5:ticket:27156). However, you are replacing the .svg icons just with .png ones. Thus, I guess that does not take care of those displays and would show the Tor Browser icon blurry.

comment:4 Changed 9 months ago by gk

Cc: mcs brade added

Closed #18058 as a duplicate.

comment:5 in reply to:  3 Changed 9 months ago by arthuredelstein

Keywords: TorBrowserTeam201810R added
Status: needs_revisionneeds_review

Replying to gk:

Thanks for pointing out the duplicate ticket.

Looking at #18058 it seems Mozilla previously used

browser/branding/official/content/identity-icons-brand.png
browser/branding/official/content/identity-icons-brand@2x.png

and similar files. It seems we need the @2x.png for high resolution displays on macOS unless we resort to .svg files (see comment:5:ticket:27156). However, you are replacing the .svg icons just with .png ones. Thus, I guess that does not take care of those displays and would show the Tor Browser icon blurry.

The PNG file I used is 32x32 whereas the icon in that location is sized to 16x16. So I think these PNGs are effectively @2x already.

comment:6 Changed 9 months ago by gk

Hm, I wonder why Mozilla used two differnt icons for that then if they just could have used a 32x32 one. What speaks against moving to .svg as Mozilla eventually did?

comment:7 in reply to:  6 Changed 9 months ago by arthuredelstein

Replying to gk:

Hm, I wonder why Mozilla used two differnt icons for that then if they just could have used a 32x32 one.

I'm not sure. I guess in principle it's more performant to have the image already at the scale you need. Although it seems unlikely it's a bottleneck.

What speaks against moving to .svg as Mozilla eventually did?

Nothing, except I couldn't find an SVG version of the green globe icon. If anyone has a copy of it I will be glad to make a new patch using the SVG instead.

comment:8 Changed 9 months ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201810R removed

Moving reviews to November.

comment:9 Changed 8 months ago by pospeselr

Cc: arthuredelstein tbb-team added
Description: modified (diff)
Owner: changed from tbb-team to pospeselr
Parent ID: #25702
Status: needs_reviewassigned

I can actually swap this out with an SVG with the new branding as part of #25702.

comment:10 in reply to:  9 Changed 8 months ago by gk

Keywords: TorBrowserTeam201811 added; TorBrowserTeam201811R removed

Replying to pospeselr:

I can actually swap this out with an SVG with the new branding as part of #25702.

I was just about to propose that while thinking about this ticket over the weekend. :) Thanks!

comment:11 Changed 7 months ago by gk

Keywords: TorBrowserTeam201812 added; TorBrowserTeam201811 removed

Moving our tickets to December.

comment:12 Changed 6 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201812 removed

Moving tickets to Jan 2019.

comment:13 Changed 6 months ago by gk

Resolution: fixed
Status: assignedclosed

That's fixed with commit 7f7a40f907f74a531642a5cb4982f2d762316d38 on tor-browser-60.4.0esr-8.5-1.

Note: See TracTickets for help on using tickets.