Opened 5 weeks ago

Closed 4 weeks ago

#28115 closed defect (fixed)

0.3.5.3 FTBFS on mips and s390

Reported by: weasel Owned by: nickm
Priority: Very High Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.3-alpha
Severity: Major Keywords:
Cc: Actual Points: .1
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

Tor 0.3.5.3-alpha-1 has failed to build on s390x and mips for Debian experimental. Other mips* platforms have not yet been tried.

For now,
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=s390x&ver=0.3.5.3-alpha-1&stamp=1539844680&raw=0
and
https://buildd.debian.org/status/fetch.php?pkg=tor&arch=mips&ver=0.3.5.3-alpha-1&stamp=1539846878&raw=0
have the full build logs.

crypto/ope/vectors: 
  FAIL ../src/test/test_crypto_ope.c:141: assert(crypto_ope_encrypt(ope, val) OP_EQ res): 3968478454 vs 3971694514
  [vectors FAILED]

is common to both (same numbers too).

Additionally, on mips this happened:

storagedir/empty: [forking] OK
storagedir/basic: [forking] Oct 18 07:14:22.551 [err] tor_assertion_failed_(): Bug: ../src/test/testing_rsakeys.c:540: init_pregenerated_keys: Assertion r == 0 failed; aborting. (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.553 [err] Bug: Assertion r == 0 failed in init_pregenerated_keys at ../src/test/testing_rsakeys.c:540. Stack trace: (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.553 [err] Bug:     ./src/test/test(log_backtrace_impl+0x84) [0x55cb65f8] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug:     ./src/test/test(tor_assertion_failed_+0xc4) [0x55cb1188] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug:     ./src/test/test(init_pregenerated_keys+0x198) [0x55a9b130] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug:     ./src/test/test(testcase_run_one+0x2d8) [0x55a9b530] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.554 [err] Bug:     ./src/test/test(tinytest_main+0x188) [0x55a9be64] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.555 [err] Bug:     ./src/test/test(main+0x3ec) [0x556ec43c] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.555 [err] Bug:     /lib/mips-linux-gnu/libc.so.6(__libc_start_main+0x108) [0x76f48cf8] (on Tor 0.3.5.3-alpha )
Oct 18 07:14:22.555 [err] Bug:     ./src/test/test(+0x5f5b4) [0x556ec5b4] (on Tor 0.3.5.3-alpha )

Child Tickets

Change History (10)

comment:1 Changed 5 weeks ago by nickm

Priority: MediumVery High
Severity: BlockerMajor

Looks like the first one is happening on the various big-endian platforms. Probably it's a bug in the OPE code, though I am not yet seeing where.

comment:2 Changed 5 weeks ago by nickm

Owner: set to nickm
Status: newaccepted

comment:3 Changed 5 weeks ago by nickm

Status: acceptedneeds_review

See branch ticket28115_035 for a trivial fix to the first issue.
PR: https://github.com/torproject/tor/pull/419

comment:4 Changed 5 weeks ago by nickm

Actual Points: .1

comment:5 Changed 5 weeks ago by weasel

Tried it manually on s390x, and it built.

comment:6 Changed 4 weeks ago by dgoulet

Reviewer: ahf

comment:8 Changed 4 weeks ago by ahf

Status: needs_reviewmerge_ready

LGTM!

comment:9 Changed 4 weeks ago by nickm

ok, merged!

comment:10 Changed 4 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.