Provide Tor Browser for Android for arm64-v8a devices

added GeorgKoppen201906 TorBrowserTeam201907R blog component::applications/tor browser owner::tbb-team priority::high resolution::fixed severity::normal status::closed tbb-backported tbb-mobile tbb-rbm type::defect user-feedback labels

hi, i need to install Tor Browser for Ubuntu on an arm64 architekure.

I couldnt find any linux release for arm64, so i tried to build tor browser on my device (rockpro64, Ubuntu Bionic 18.04.1 arm64). I used the git clone https://git.torproject.org/builders/tor-browser-build.git but i read in the README make will only produce a version for armv71 and I386/amd64. i went further anyway executed make [file], i think the output is the following file: /tor-browser-build/out/debootstrap-image/container-image_ubuntu-base-18.04.1-base-amd64.tar.gz

but what now? Is it Possible? Exist already a build? is it neccesary to install tor browser, tor itself and mozilla is availible in my package repository?

Thanks and greetings Mark

Trac:
Username: peredor

Replying to peredor:

i need to install Tor Browser for Ubuntu on an arm64 architekure. You can join #12631 (moved) and add rbm descriptors for aarch64.

Replying to cypherpunks2:

Replying to peredor:

i need to install Tor Browser for Ubuntu on an arm64 architekure. You can join #12631 (moved) and add rbm descriptors for aarch64.

Thanks a lot, i found this ticket already in the past but thougt this wouldn't work for me. buying a modern SBC is how entering a Linux Lesson, you have to learn much :) Try my best

Trac:
Username: peredor

We need to provide 64bit .apks by August this year for Google App Store which is why I gave this a shot. bug_28119 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_28119) is the result. It gives me an .apk \o/ There is at least the Orbot piece missing, though, as it seems there is no aarch64 Orbot support yet. sisbell: How much of the Orbot stuff do we care here? I am wondering how much time I should spend fixing this up.

Trac:
Status: new to needs_information
Priority: Medium to High
Keywords: N/A deleted, TorBrowserTeam201902, GeorgKoppen201902 added

Replying to gk:

We need to provide 64bit .apks by August this year for Google App Store which is why I gave this a shot. bug_28119 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_28119) is the result. It gives me an .apk \o/ There is at least the Orbot piece missing, though, as it seems there is no aarch64 Orbot support yet. sisbell: How much of the Orbot stuff do we care here? I am wondering how much time I should spend fixing this up.

Current Android devices will provide a backwards compatibility for 32 bit versions. What we can't do is mix and match libraries. Once you include one arm64-v8a library, all libraries will need to be compiled for arm64, otherwise a link error will be thrown.

So the Orbot piece would be required:

if you include any other arm64 library in the project OR
we attempt to upload to Google Play after July of this year

Otherwise it will run just fine on 64 bit devices.

Replying to sisbell:

Replying to gk:

We need to provide 64bit .apks by August this year for Google App Store which is why I gave this a shot. bug_28119 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/log/?h=bug_28119) is the result. It gives me an .apk \o/ There is at least the Orbot piece missing, though, as it seems there is no aarch64 Orbot support yet. sisbell: How much of the Orbot stuff do we care here? I am wondering how much time I should spend fixing this up.

Current Android devices will provide a backwards compatibility for 32 bit versions. What we can't do is mix and match libraries. Once you include one arm64-v8a library, all libraries will need to be compiled for arm64, otherwise a link error will be thrown.

So the Orbot piece would be required:

if you include any other arm64 library in the project OR

we attempt to upload to Google Play after July of this year

Otherwise it will run just fine on 64 bit devices.

Yes. My question was more like, what do we need from the Orbot stuff we ship now, after TOPL is used instead because I was wondering how much time I should spend on fixing the Orbot stuff.

Okay, I got another reminder from Google about Tor Browser being in need for an arm64 version, so I dusted my old patch off. bug_28119_v4 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28119_v4&id=a5dba4f2c96c15a6ad88d2d63190105dbc5185db) has the patch for review.

Here is a testbuild:

https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-aarch64-multi-qa.apk https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-aarch64-multi-qa.apk.asc

Trac:
Keywords: TorBrowserTeam201902, GeorgKoppen201902 deleted, GeorgKoppen201905, TorBrowserTeam201905R added
Status: needs_information to needs_review

Replying to gk:

Okay, I got another reminder from Google about Tor Browser being in need for an arm64 version, so I dusted my old patch off. bug_28119_v4 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28119_v4&id=a5dba4f2c96c15a6ad88d2d63190105dbc5185db) has the patch for review.

I see we set a different value for var/android_min_api for aarch64 and the other architectures. However, in projects/android-toolchain/build, we create one toolchain tarball containing all architectures, and we use var/android_min_api for all of them. However var/android_min_api only contains the value corresponding to the architecture we are currently building. So I think we should not use var/android_min_api in projects/android-toolchain/build, and instead do something like this:

./build/tools/make_standalone_toolchain.py --api 16 --arch arm --install-dir=./arm
./build/tools/make_standalone_toolchain.py --api 16 --arch x86 --install-dir=./x86
./build/tools/make_standalone_toolchain.py --api 21 --arch aarch64 --install-dir=./aarch64

Or to avoid duplicating the api version in two places:

diff --git a/projects/android-toolchain/build b/projects/android-toolchain/build
index 588aab9..e0f59a9 100644
--- a/projects/android-toolchain/build
+++ b/projects/android-toolchain/build
@@ -18,11 +18,9 @@ cd $NDK_HOME
 mv android-ndk-r15c/* .
 rm -fR android-ndk-r15c
 
-# The architectures we support
-archs="arm x86 arm64"
-for arch in $archs; do
-  ./build/tools/make_standalone_toolchain.py --api [% c("var/android_min_api") %] --arch $arch --install-dir=./$arch
-done
+./build/tools/make_standalone_toolchain.py --api [% c("var/android_min_api_armv7") %] --arch arm --install-dir=./arm
+./build/tools/make_standalone_toolchain.py --api [% c("var/android_min_api_x86") %] --arch x86 --install-dir=./x86
+./build/tools/make_standalone_toolchain.py --api [% c("var/android_min_api_aarch64") %] --arch arm64 --install-dir=./arm64
 
 # Tool Archives
 cd $SDK_HOME
diff --git a/rbm.conf b/rbm.conf
index c344e6f..fe3f406 100644
--- a/rbm.conf
+++ b/rbm.conf
@@ -196,15 +196,17 @@ targets:
     arch: aarch64
     var:
       android-aarch64: 1
-      # API 21 is the minimum we currently support for arm64 on Android
-      android_min_api: 21
       osname: android-aarch64
   android:
     var:
       android: 1
       compiler: android-toolchain
       # API 16 is the minimum we currently support for Tor Browser on Android
-      android_min_api: 16
+      android_min_api: '[% SET arch = c("var/arch"); GET c("var/android_min_api_" _ arch) %]'
+      # API 21 is the minimum we currently support for arm64 on Android
+      android_min_api_aarch64: 21
+      android_min_api_armv7: 16
+      android_min_api_x86: 16
       snowflake: 0
       container:
         suite: stretch

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201905R deleted, TorBrowserTeam201905 added

Trac:
Keywords: N/A deleted, blog, user-feedback added

Moving tickets to June

Trac:
Keywords: TorBrowserTeam201905 deleted, TorBrowserTeam201906 added

Moving my tickets to June

Trac:
Keywords: GeorgKoppen201905 deleted, GeorgKoppen201906 added

Alright, to avoid further bitrot I added the remaining parts requested in boklm's review (and fixed things up a bit). bug_28119_v6 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28119_v6&id=d226510faec5480997adcdc3c1c6aee1952d92e5) is the new version for review. A test bundle built from that is:

https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-28119-android-aarch64-multi-qa.apk https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-28119-android-aarch64-multi-qa.apk.asc

Trac:
Keywords: TorBrowserTeam201906 deleted, TorBrowserTeam201906R added
Status: needs_revision to needs_review

No reviews in June 2019 anymore, moving them.

Trac:
Keywords: TorBrowserTeam201906R deleted, TorBrowserTeam201907R added

This looks good to me. I merged it to master with commit 99f739a2b2bde7e81d9f6a974efbdd2eca1b7947.

I opened #31054 (moved) to enable it in the nightly builds.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

I also seems the branch bug_28119_v6 was pushed by mistake to the main tor-browser-build repository (not in the master branch, but in a bug_28119_v6 branch).

Replying to boklm:

I also seems the branch bug_28119_v6 was pushed by mistake to the main tor-browser-build repository (not in the master branch, but in a bug_28119_v6 branch).

Yeah :( That's #31007 (moved).

Note: when backporting we need to backport a Tor Browser patch, too, to allow publishing on Google Play.

Trac:
Keywords: N/A deleted, tbb-backport added

Replying to gk:

Note: when backporting we need to backport a Tor Browser patch, too, to allow publishing on Google Play.

That got already done in #31260 (moved).

I cherry-picked the patch onto maint-8.5 (commit 1eeda4986c5f88f07bf53a2801e9e32ba3dba80b).

Trac:
Keywords: tbb-backport deleted, tbb-backported added

closed

Provide Tor Browser for Android for arm64-v8a devices

Child items 0

Activity