Opened 14 months ago

Last modified 7 months ago

#28158 new enhancement

Vote for relay bandwidths even if the min percentage has not been reached

Reported by: juga Owned by:
Priority: Medium Milestone: sbws: 1.2.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: sbws-1.0-must-moved-20181128, sbws-11x-final-removed-20190312, sbws-110-proposed, changes-version-minor, sbws-110-removed-20190312
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

In #28062 we add additional header lines when the minimum percentage of measured relays that pass some restrictions and do not write any bandwidth lines.
A dirauth asked if that is better that writing the few bandwidth lines.
The reason why we do it is because torflow does it and we want sbws 1.0 to behave as torflow.
In future sbws versions, we might prefer to include the bandwidth lines

Child Tickets

Change History (14)

comment:1 Changed 13 months ago by teor

Milestone: sbws 1.1
Type: defectenhancement

comment:2 Changed 13 months ago by teor

Milestone: sbws 1.1sbws 1.0 (MVP must)
Parent ID: #28547

We must do this ticket to monitor excluded relays

comment:3 Changed 13 months ago by teor

Keywords: sbws-1.0-must-moved-20181128 added
Milestone: sbws 1.0 (MVP must)sbws 1.0.4

Moving all sbws 1.0 must planning and feature tickets to 1.0.4.

comment:4 Changed 13 months ago by teor

Milestone: sbws 1.0.4sbws 1.1

Milestone renamed

comment:5 Changed 13 months ago by teor

Milestone: sbws 1.1sbws: 1.1.x

Milestone renamed

comment:6 Changed 13 months ago by teor

Milestone: sbws: 1.1.xsbws: 1.1.x-final

Milestone renamed

comment:7 Changed 9 months ago by juga

Keywords: sbws-11x-final-removed-20190312 sbws-110-proposed changes-version-minor added
Milestone: sbws: 1.1.x-finalsbws: 1.1.0

Move tickets that imply a minor version change to 1.1.0.

comment:8 Changed 9 months ago by juga

Cc: pastly juga teor removed
Keywords: sbws-110-removed-20190312 added
Milestone: sbws: 1.1.0sbws: unspecified
Parent ID: #28547
Points: 1

Removing from 1.1.0 since it wait. Unparenting.

comment:9 Changed 9 months ago by teor

We need to be able to explain to a relay operator why sbws has excluded their relay.
How can we do that if we don't do this ticket?

comment:10 in reply to:  9 ; Changed 9 months ago by juga

Replying to teor:

We need to be able to explain to a relay operator why sbws has excluded their relay.
How can we do that if we don't do this ticket?

Hmm, do you think we can postpone this after #28547 is implemented so that we confirm why sbws is excluding more relays than Torflow?.

Have there been so far questions like this (with Torflow)?.
Do you know where would be the place where a relay operator would look at to search for this type of information?.

If we add them, just without bw key so that Tor doesn't parse it, relay operators will see their relay, but still might question why it is not measured in the consensus.

Edit: grammar, typo, more typos

Last edited 9 months ago by juga (previous) (diff)

comment:11 in reply to:  10 Changed 9 months ago by teor

Replying to juga:

Replying to teor:

We need to be able to explain to a relay operator why sbws has excluded their relay.
How can we do that if we don't do this ticket?

Hmm, do you think we can postpone this after #28547 is implemented so that we confirm why sbws is excluding more relays than Torflow?.

We can see if #28547 helps us work out why relays are not being measured.
But if relays are never measured, we will need to implement this ticket to see them in the v3bwfile.

Have there been so far questions like this (with Torflow)?.
Do you know where would be the place where a relay operator would look at to search for this type of information?.

Torflow does not provide much diagnostic information per relay.
sbws need to provide better information, so we can fix the bugs that make it worse than torflow.

The votes provide a small amount of information, it is available in consensus-health in the big relay table:
https://consensus-health.torproject.org/consensus-health-2019-03-13-10-00.html#000A10D43011EA4928A35F610405F92B4433B4DC

There are bw and bwauth lines for each relay in consensus-health.

If we add them, just without bw key so that Tor doesn't parse it, relay operators will see their relay, but still might question why it is not measured in the consensus.

We have this ticket so we can answer the questions that relay operators ask when their relays are not measured.

comment:12 Changed 9 months ago by juga

I probably should have make a clarification in the description or maybe even two different tickets.

One thing would be to include all the "non-eligible relays" lines, as lines that Tor will not currently parse.
Other different thing is to report all "eligible relays", even if they are not the 60% of the relays in the network.
The latest would still not show us the "non-eligible relays" and the percent would not change.
The former would facilitate that the 60% is reached, but would still not show any line if both eligible and non-eligible relays are less than the 60%, what would happen when the scanner is just starting, or stop for a while.

comment:13 in reply to:  12 Changed 9 months ago by teor

Summary: Consider writing bw lines even if the min percentage has not been reachedVote for relay bandwidths even if the min percentage has not been reached

Replying to juga:

I probably should have make a clarification in the description or maybe even two different tickets.

You're right, this ticket is hard to understand. I fixed the title.

One thing would be to include all the "non-eligible relays" lines, as lines that Tor will not currently parse.

Let's change the relays that are in the bandwidth file, but tor won't vote on them, in #28563.

Other different thing is to report all "eligible relays", even if they are not the 60% of the relays in the network.

Ok, let's change the relays that tor will vote on in this ticket.

So we don't need to do this ticket any time soon.

comment:14 Changed 7 months ago by teor

Milestone: sbws: unspecifiedsbws: 1.2.x-final

It would be nice to make these changes in sbws 1.2

Note: See TracTickets for help on using tickets.