Opened 13 months ago

Closed 13 months ago

Last modified 12 months ago

#28159 closed defect (fixed)

Consider disabling rtt measurements

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: sbws-1.0-nice-closed-moved-20181128
Cc: pastly, juga, teor Actual Points:
Parent ID: #28042 Points:
Reviewer: Sponsor:

Description

So that the scanner is able to measure more relays per day.
RTT is not being used at the moment, it can be enabled again in a future version or with an option.

Child Tickets

Change History (7)

comment:1 Changed 13 months ago by pastly

Users can do so by setting the appropriate option in their config. No code changes necessary.

comment:2 Changed 13 months ago by juga

You mean num_rtts [0]?.
The minimun is 1, then maybe it should be changed to allow 0 [1]
What makes generate hit an exception [2].
The changes required are minimal anyway.
I'm running now the code with those changes. I'll check the number of relays measured running it like this after 1 day.

[0] https://gitweb.torproject.org/sbws.git/tree/sbws/config.default.ini#n45
[1] https://gitweb.torproject.org/sbws.git/tree/sbws/util/config.py#n239
[2] https://gitweb.torproject.org/sbws.git/tree/sbws/lib/v3bwfile.py#n382

comment:3 Changed 13 months ago by pastly

My bad.

Yes I think the minimum allowed should be 0 and a change added to generate so that it doesn't freak out when there are no RTT results.

comment:4 Changed 13 months ago by juga

Status: assignedneeds_revision

comment:5 Changed 13 months ago by juga

Status: needs_revisionneeds_review

ops

comment:6 Changed 13 months ago by juga

Resolution: fixed
Status: needs_reviewclosed

Merged

comment:7 Changed 12 months ago by teor

Keywords: sbws-1.0-nice-closed-moved-20181128 added
Milestone: sbws 1.0 (MVP nice)sbws: 1.0.x-final

Move all closed sbws 1.0 nice tickets to sbws 1.0.x-final

Note: See TracTickets for help on using tickets.