Opened 9 months ago

Last modified 5 months ago

#28200 needs_information defect

Update downloader does not automatically retry when connection is interrupted

Reported by: traumschule Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-update
Cc: mcs, brade, teor Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The about dialog showed a download in progress and suddenly stopped. I had to close the about dialog and reopen it to continue the download. teor confirmed that on irc:

I have seen Tor Browser time out on updates on my macOS VM. Possibly because the VM is overloaded.

TB should recognize an interrupted connection and restart the download automatically.

Child Tickets

Change History (7)

comment:1 Changed 9 months ago by gk

Cc: mcs brade added
Status: newneeds_information

What is Firefox 60 ESR doing in such a case? I.e. is that a more generic bug in Firefox's code or something we messed up when adding our patches?

comment:2 Changed 9 months ago by traumschule

I went through tickets filed by teor in 2016 and 2017 to check if this is maybe a duplicate. These are related to the updater:
#16812 #18186 #20150 #22598 #22598 #23115 #23798

What is Firefox 60 ESR doing in such a case?

Unplugging the cable did not irritate it much, it just continued when replugging it after some time. However the update is so small that i had to wondershaper [iface] 10 10, still then it did not show a progress bar, just a spinner with "Checking for updates..." and then the restart button.
So i used iptables to drop packets for the created firefox user (iptables -I OUTPUT -m owner --uid-owner 100X -j DROP), started firefox and it claimed "Firefox is up to date". Is this filed upstream already?

Maybe giving users the chance to interact with a Refresh button is easier than implementing a lot of logic here.

comment:3 in reply to:  2 Changed 9 months ago by gk

Replying to traumschule:

I went through tickets filed by teor in 2016 and 2017 to check if this is maybe a duplicate. These are related to the updater:
#16812 #18186 #20150 #22598 #22598 #23115 #23798

What is Firefox 60 ESR doing in such a case?

Unplugging the cable did not irritate it much, it just continued when replugging it after some time. However the update is so small that i had to wondershaper [iface] 10 10, still then it did not show a progress bar, just a spinner with "Checking for updates..." and then the restart button.
So i used iptables to drop packets for the created firefox user (iptables -I OUTPUT -m owner --uid-owner 100X -j DROP), started firefox and it claimed "Firefox is up to date". Is this filed upstream already?

Good question, I don't know.

Maybe giving users the chance to interact with a Refresh button is easier than implementing a lot of logic here.

Could be, yes.

comment:4 Changed 9 months ago by traumschule

Cc: teor added

comment:5 Changed 9 months ago by traumschule

Summary: Update fails when connection is interruptedUpdate downloader does not automatically retry when connection is interrupted

comment:6 Changed 6 months ago by gk

Keywords: tbb-updater added

comment:7 Changed 5 months ago by gk

Keywords: tbb-update added; tbb-updater removed

Renaming keyword to make it a bit broader

Note: See TracTickets for help on using tickets.