Opened 13 months ago

Last modified 6 months ago

#28247 needs_revision defect

Use build.rs in place of test_linking_hack

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-can, 035-deferred-20190115, 041-proposed
Cc: alexcrichton, teor Actual Points: .1
Parent ID: #28244 Points: .1
Reviewer: catalyst Sponsor:

Child Tickets

Change History (10)

comment:1 Changed 13 months ago by nickm

Keywords: 035-can added

comment:2 Changed 13 months ago by nickm

Owner: set to nickm
Points: .1
Status: newaccepted

comment:3 Changed 13 months ago by nickm

Actual Points: .1
Status: acceptedneeds_review

See branch bug28247_035 with PR at https://github.com/torproject/tor/pull/498 .

comment:4 Changed 13 months ago by dgoulet

Reviewer: catalyst

comment:5 Changed 13 months ago by catalyst

Status: needs_reviewneeds_revision

The pull request seems to fail Travis, but only in the Rust builds. Maybe something is missing? It seems related to the Rust linker somehow? I haven't investigated further yet.

comment:6 Changed 13 months ago by nickm

Status: needs_revisionneeds_review

Oh, wow. I think this depends on make order, and the solution is to add a dependency to the rust library, but I want to make sure we haven't messed anything up here. I've added an extra commit.

comment:7 Changed 12 months ago by nickm

Status: needs_reviewneeds_revision

Huh. This is putting me back into the land of asan failures. I'm confused now.

comment:8 Changed 11 months ago by nickm

Keywords: 035-deferred-20190115 041-proposed added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

Marking a number of 0.3.5 tickets as possible, maybe even a good idea, for later. Possibly backportable, some of them. But not currently things to do as part of 0.3.5 stabilization.

comment:9 Changed 6 months ago by nickm

Owner: nickm deleted
Status: needs_revisionassigned

comment:10 Changed 6 months ago by nickm

Status: assignedneeds_revision

None of these revisions are in my near-term plans.

Note: See TracTickets for help on using tickets.