Opened 9 months ago

Last modified 9 months ago

#28250 new enhancement

"___UsingTestNetworkDefaults" not in "GETINFO config/names"

Reported by: Logforme Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.3.10
Severity: Trivial Keywords: tor-control
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by nickm)

I played around with my little Tor relay monitor and when I tried to get the config options I noticed that the option __UsingTestNetworkDefaults is not returned by "GETINFO config/names". It is however returned by "GETINFO config/defaults"
Maybe an easy fix to put in the low priority queue?

Child Tickets

Change History (3)

comment:1 Changed 9 months ago by nickm

Description: modified (diff)

comment:2 Changed 9 months ago by Logforme

Had a look in the source code. Seems it's deliberately kept out of the config/names list:
config.c line 8173:

/* don't tell controller about triple-underscore options */
if (!strncmp(option_vars_[i].name, "___", 3))
   continue;

Shouldn't it use the var pointer instead?

/* don't tell controller about triple-underscore options */
if (!strncmp(var->name, "___", 3))
   continue;

Guess those lines should be added to the config/defaults handling as well in config.c line 8214

Last edited 9 months ago by Logforme (previous) (diff)

comment:3 Changed 9 months ago by asn

Keywords: tor-control added
Milestone: Tor: unspecified
Priority: Very LowMedium
Note: See TracTickets for help on using tickets.