#28261 closed defect (fixed)

Please provide the english language strings for Torbutton under "en-US" and not "en" as it is now

Reported by: gk Owned by: gk
Priority: Medium Milestone:
Component: Community/Translations Version:
Severity: Normal Keywords:
Cc: igt0, hiro, ggus Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We ship "en-US" bundles, yet the language strings are under "en" in Torbutton. That leads to hacks like the one igt0 tried in #25013. We should fix the root cause here, though, which is that the language strings should be located under "en-US" given that there is no standalone Torbutton and there are no "en" bundles we distribute

Child Tickets

Change History (8)

comment:1 Changed 13 months ago by emmapeel

Status: newneeds_review

OK I think this is finally done. Let me know if you find any problems.

comment:2 Changed 13 months ago by emmapeel

Owner: changed from emmapeel to geko
Status: needs_reviewassigned

comment:3 Changed 13 months ago by emmapeel

Owner: changed from geko to gk

comment:4 Changed 13 months ago by gk

Owner: changed from gk to emmapeel

Let's do the "ditch en"-part here as well.

comment:5 Changed 13 months ago by emmapeel

So, you mean we ditch it all around the tor browser components, and not only in torbutton-* components?

comment:6 Changed 13 months ago by gk

Let's do Torbutton in this ticket and see how it goes and file new ones for other components if we think we are good.

comment:7 Changed 13 months ago by emmapeel

Owner: changed from emmapeel to gk

OK, I have deleted the en folder everywhere on the torbutton resources translation... it should be gone.

Let me know if it looks good from your side.

comment:8 Changed 13 months ago by gk

Resolution: fixed
Status: assignedclosed

Looks good, closing. I've opened #28515 for the Torbutton changes.

Note: See TracTickets for help on using tickets.