Opened 2 years ago

Closed 20 months ago

#28286 closed defect (fixed)

Missing header in freespace.c when building for Android

Reported by: goapunk Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.3-alpha
Severity: Normal Keywords:
Cc: goapunk@… Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Building tor 0.3.5.3-alpha for Android fails with the following error:

src/lib/fs/freespace.c: In function 'tor_get_avail_disk_space':
src/lib/fs/freespace.c:59:3: error: 'errno' undeclared (first use in this function)
   errno = ENOSYS;
   ^
src/lib/fs/freespace.c:59:3: note: each undeclared identifier is reported only once for each function it appears in
src/lib/fs/freespace.c:59:11: error: 'ENOSYS' undeclared (first use in this function)
   errno = ENOSYS;
           ^
Makefile:9088: recipe for target 'src/lib/fs/freespace.o' failed

On Android <errno.h> should be included in the header.

Child Tickets

Change History (7)

comment:1 Changed 2 years ago by goapunk

Cc: goapunk@… added

comment:2 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:3 Changed 2 years ago by nickm

Status: acceptedneeds_review

Fix in branch bug28286_035 with PR in https://github.com/torproject/tor/pull/467

comment:4 Changed 23 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

Quite trivial. ACK.

comment:5 Changed 23 months ago by dgoulet

Milestone: Tor: unspecified

comment:6 Changed 20 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.5.x-final

comment:7 Changed 20 months ago by asn

Resolution: fixed
Status: merge_readyclosed

This patch seems to have been merged to 035 and forward back in January: b33bcb1e63c25d9107dfb7b1aa7ecd600674b352

https://gitweb.torproject.org/tor.git/commit/?id=b33bcb1e63c25d9107dfb7b1aa7ecd600674b352

Closing.

Note: See TracTickets for help on using tickets.