Opened 10 months ago

Closed 8 months ago

Last modified 8 months ago

#28297 closed defect (implemented)

Control interpreter in nyx does not do line splitting

Reported by: wagon Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Nyx Version: Tor: 0.3.4.8
Severity: Normal Keywords:
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When GETINFO circuit-status is typed in control interpreter of nyx (2.0.4), long lines are not split. Therefore, full tor's reply cannot be seen. It looks like (names of Tor nodes are fake):

>>> GETINFO circuit-status
250+circuit-status=       
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~nodeone,$FINGE
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~nodetwotwo2,$F
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~node11,$FINGER
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~nodethree1,$FI
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~tnode,$FINGERP
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~Unnamed,$FINGE
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~anothernode,$F
XXXX BUILT $FINGERPRINT~NODENAME,$FINGERPRINT~nodenew2,$FING
.   
250 OK

Other commands which output long lines may also have this problem.

Interestingly, contrary to nyx, tor-prompt do line splitting correctly.

Child Tickets

Change History (4)

comment:1 Changed 10 months ago by wagon

Component: ApplicationsCore Tor/Nyx
Keywords: nyx removed
Reviewer: atagar

comment:2 Changed 10 months ago by atagar

Hi wagon, this is an interesting catch - thanks! Nyx and tor-prompt share the same functionality but use very different display their output. tor-prompt uses readline whereas Nyx uses curses. With curses I need to do line wrapping myself so unsurprising I missed it here - thanks!

comment:3 Changed 8 months ago by atagar

Resolution: implemented
Status: assignedclosed

Hi wagon, thanks again for the feature request! This was a good one. Nyx's interpreter now does line wrapping.

https://gitweb.torproject.org/nyx.git/commit/?id=75052e8

comment:4 Changed 8 months ago by wagon

Thanks!

Note: See TracTickets for help on using tickets.