Opened 2 weeks ago

Closed 13 days ago

#28318 closed enhancement (implemented)

Appveyor: build on Windows Server 2012 R2 and Windows Server 2016

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix, test, appveyor, tor-ci
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:

Description

Appveyor provides build images with Windows Server 2012 R2 (the default) and Windows Server 2016. These images are called:

  • Visual Studio 2015
  • Visual Studio 2017

https://www.appveyor.com/docs/windows-images-software/#operating-system

Our builds work on these images:
https://ci.appveyor.com/project/teor2345/tor/builds/20046114

So we should probably build on both of them.

Child Tickets

Change History (4)

comment:1 Changed 2 weeks ago by teor

Status: assignedneeds_review

See my branch ticket28318-035 or https://github.com/torproject/tor/pull/476

This change doubles our appveyor build time. If that's a problem, we can just build x86-64 on Windows Server 2016.

comment:2 Changed 2 weeks ago by dgoulet

Reviewer: nickm

comment:3 Changed 13 days ago by nickm

lgtm; moved to 0.3.5 and forward.

comment:4 Changed 13 days ago by nickm

Resolution: implemented
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.