Changes between Initial Version and Version 1 of Ticket #28329, comment 40


Ignore:
Timestamp:
Mar 14, 2019, 8:42:50 AM (7 months ago)
Author:
gk
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28329, comment 40

    initial v1  
    11Here comes the detailed review adding to the things mentioned in my previous comments. Overall: really nice work! The biggest issue I have is dealing with our bridge pref handling. I feel we should try avoid custom parsing code (aka TorBridgeList.java). It's less error prone and probably easier to just write a script that converts the .js file we have right now for desktop into whatever is easiest to deal with on mobile during our build.
    22
    3 Anyway, here are my comments: I looked at the code commit-wise and then for b2c12e4881e3aacf192d3cf623028246f40ab3c4 I wrote comments down per file and for `TorPreferences.java` per class and method. This review is based on code in `28329_v6`.
     3Anyway, here are my comments: I looked at the code commit-wise and then for b2c12e4881e3aacf192d3cf623028246f40ab3c4 I wrote comments down per file and for `TorPreferences.java` per class and method. This review is based on code in `28329_6`.
    44
    55dc4d883cefa60af9caa3894360e7f07992174fa1 - not okay