Opened 4 months ago

Closed 4 months ago

#28330 closed enhancement (implemented)

Make a "subsystem manager" API to handle module setup/teardown/etc

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 1.5
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description


Child Tickets

Change History (8)

comment:1 Changed 4 months ago by nickm

Status: assignedneeds_review

See branch subsystems with PR at https://github.com/torproject/tor/pull/478

This code is related to, but not dependent on, the publish/subscribe messaging stuff in #28226

comment:2 Changed 4 months ago by dgoulet

Reviewer: dgoulet

comment:3 Changed 4 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:4 Changed 4 months ago by dgoulet

Status: needs_reviewneeds_revision

comment:5 Changed 4 months ago by dgoulet

Oh there is another thing about the subsystem level. I'm not sure how the values were decided but either way, we would strongly benefit from having them written down in one single place (maybe within the subsystem array?) so when a new one is added, one doesn't have to go through ALL the subsystems to know what level would be good to use.

comment:6 Changed 4 months ago by nickm

Status: needs_revisionneeds_review

Okay, I've made the requested changes.

comment:7 Changed 4 months ago by dgoulet

Status: needs_reviewmerge_ready

comment:8 Changed 4 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.