Opened 7 months ago

Last modified 3 months ago

#28344 new defect

Should we log \r\n on Windows?

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix, 040-roadmap-proposed, 040-deferred-20190220
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor's logging code terminates strings with \n.

When I run tor.exe via the command prompt on Windows, I don't see any of the log output, because there's no \r at the end of the line.

Should we make tor log \r\n on Windows?

Child Tickets

Change History (4)

comment:1 Changed 7 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.6.x-final

I think the "binary v text" flag here might also be what we want? And we might want different rules for stream-logs and file-logs?

comment:2 Changed 7 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:3 Changed 6 months ago by teor

Keywords: 040-roadmap-proposed added; 036-roadmap-proposed removed

0.3.6 is now 0.4.0: changing roadmap keywords

comment:4 Changed 3 months ago by nickm

Keywords: 040-deferred-20190220 added
Milestone: Tor: 0.4.0.x-finalTor: unspecified

Deferring 51 tickets from 0.4.0.x-final. Tagging them with 040-deferred-20190220 for visibility. These are the tickets that did not get 040-must, 040-can, or tor-ci.

Note: See TracTickets for help on using tickets.