Opened 8 days ago

Last modified 2 days ago

#28348 merge_ready defect

Setting DisableNetwork won't disable NEED_NET events

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-backport
Cc: Actual Points:
Parent ID: #28335 Points: 0
Reviewer: dgoulet Sponsor: Sponsor8

Description

In rescan_periodic_events(), we skip the enable/disable code for NEED_NET events when net_is_disabled(). That is sufficient to prevent them from being enabled, but it doesn't cause them to become disabled.

Child Tickets

Change History (5)

comment:1 Changed 8 days ago by nickm

Status: assignedneeds_review

There's a fix in branch bug28348_034 with PR at https://github.com/torproject/tor/pull/482 . Please review?

There's a merge conflict with 0.3.5, so I've done the merge as branch bug28348_035 with PR at https://github.com/torproject/tor/pull/481 .

Last edited 8 days ago by nickm (previous) (diff)

comment:2 Changed 8 days ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm!

comment:3 Changed 8 days ago by nickm

okay. Let's try it out in 0.3.5, in case it breaks anything.

comment:4 Changed 8 days ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.4.x-final

Merged to 0.3.5; marking for 0.3.4 backport.

comment:5 Changed 2 days ago by nickm

Parent ID: #28335
Note: See TracTickets for help on using tickets.