Opened 2 months ago

Last modified 4 days ago

#28348 merge_ready defect

Setting DisableNetwork won't disable NEED_NET events

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-backport
Cc: Actual Points:
Parent ID: Points: 0
Reviewer: dgoulet Sponsor:

Description

In rescan_periodic_events(), we skip the enable/disable code for NEED_NET events when net_is_disabled(). That is sufficient to prevent them from being enabled, but it doesn't cause them to become disabled.

Child Tickets

Change History (11)

comment:1 Changed 2 months ago by nickm

Status: assignedneeds_review

There's a fix in branch bug23848_034 with PR at https://github.com/torproject/tor/pull/482 . Please review?

There's a merge conflict with 0.3.5, so I've done the merge as branch bug23848_035 with PR at https://github.com/torproject/tor/pull/481 .

Version 0, edited 2 months ago by nickm (next)

comment:2 Changed 2 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm!

comment:3 Changed 2 months ago by nickm

okay. Let's try it out in 0.3.5, in case it breaks anything.

comment:4 Changed 2 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.4.x-final

Merged to 0.3.5; marking for 0.3.4 backport.

comment:5 Changed 2 months ago by nickm

Parent ID: #28335

comment:6 Changed 7 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merging with parent.

comment:7 Changed 7 weeks ago by nickm

Resolution: fixed
Status: closedreopened

Whoops, I closed too soon. It still needs backport.

comment:8 Changed 7 weeks ago by nickm

Status: reopenedmerge_ready

comment:9 Changed 7 weeks ago by nickm

Parent ID: #28335

comment:10 Changed 2 weeks ago by nickm

Going to suggest "no backport" here -- people who want sophisticated power management need to be on 0.3.5 or 0.4.0 for other reasons.

comment:11 Changed 4 days ago by gaba

Sponsor: Sponsor8
Note: See TracTickets for help on using tickets.