#28357 closed defect (wontfix)

Stem's integ tests are broken on Travis

Reported by: teor Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I see "unknown option 'ExitRelay'" at:
https://travis-ci.org/torproject/stem/builds/451656009

Is this a stem bug, or is the version of Tor way too old?

If the Tor version is too old, we can make this ticket a child of #28170, because I'll fix it at the same time.

Child Tickets

Change History (3)

comment:1 Changed 10 months ago by atagar

Hi teor, tor's ExitRelay torrc parameter was added in November 2014.

Oddly I can't find the tor git commit the tests cite, but in checking tor's maint-0.2.4 branch that option indeed wasn't present so guess 0.2.4 is pretty antiquated.

% git checkout origin/maint-0.2.4
% grep ExitRelay doc/tor.1.txt | wc -l
0

If you provide me with the tor version when the ExitPolicy torrc option was added I can adjust stem's tests to exclude it from its integ test torrc when older than that.

comment:2 in reply to:  1 Changed 10 months ago by teor

Replying to atagar:

Hi teor, tor's ExitRelay torrc parameter was added in November 2014.

Oddly I can't find the tor git commit the tests cite

It's probably a commit in the ubuntu (or debian) downstream.

but in checking tor's maint-0.2.4 branch that option indeed wasn't present so guess 0.2.4 is pretty antiquated.

% git checkout origin/maint-0.2.4
% grep ExitRelay doc/tor.1.txt | wc -l
0

If you provide me with the tor version when the ExitPolicy torrc option was added I can adjust stem's tests to exclude it from its integ test torrc when older than that.

tor-0.2.6.3-alpha

Here's the git command to find the first version that contains a commit, for future reference:

$ git describe --contains 35efce1
tor-0.2.6.3-alpha~199^2~1

Although I do wonder if the integ tests will find more unsupported options.

In #28170, I'll fix stem's travis config so it only tests supported Tor versions (0.2.9, 0.3.3 and later).

comment:3 Changed 10 months ago by atagar

Resolution: wontfix
Status: newclosed

In #28170, I'll fix stem's travis config so it only tests supported Tor versions (0.2.9, 0.3.3 and later).

Thanks teor! To be clear my goal with Stem is to be compatible with all non-deprecated relay versions. In checking the server-versions's line of a recent consensus that's 0.2.9.14 and above.

If there's anything you think we should do on my end please let me know.

Note: See TracTickets for help on using tickets.