Opened 4 months ago

Closed 4 months ago

Last modified 2 months ago

#28362 closed enhancement (implemented)

Make sure our .may_includes files describe a noncircular dependency structure

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: .2
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

As we use the checkIncludes.py mechanism more, we'll need to make sure that we don't unintentionally introduce any circular dependencies into our structure.

Child Tickets

Change History (10)

comment:1 Changed 4 months ago by nickm

Milestone: Tor: 0.4.0.x-final
Owner: set to nickm
Status: newaccepted

My branch no_circ_includes changes checkIncludes.py to enforce this policy, fixes existing deviations from this policy, and applies this policy to (parts of) ext/ as well.

comment:2 Changed 4 months ago by nickm

Status: acceptedneeds_review

Branch is no_circ_includes, PR at https://github.com/torproject/tor/pull/488

Last edited 4 months ago by dgoulet (previous) (diff)

comment:3 Changed 4 months ago by asn

Reviewer: dgoulet

comment:4 Changed 4 months ago by dgoulet

Status: needs_reviewneeds_revision

Travis is unhappy with a code warning: https://travis-ci.org/torproject/tor/jobs/451958130

comment:5 Changed 4 months ago by nickm

Status: needs_revisionneeds_review

Tried to fix?

comment:6 Changed 4 months ago by nickm

Created a new branch 'no circ_includes_merged' to handle merge conflicts, with a new PR at https://github.com/torproject/tor/pull/507

comment:7 Changed 4 months ago by nickm

Ugh, that one didn't pass either. Created https://github.com/torproject/tor/pull/508 , which I believe will pass travis. That's the one to review.

comment:8 Changed 4 months ago by dgoulet

Status: needs_reviewmerge_ready

This change lgtm. Mostly moving around headers *but* Appveyor is failing with some OpenSSL tls function issues that are missing. Can't say if it is related to this branch but considering the header relocation, maybe.

Going in merge_ready because we can always fix that after the upstream merge but its worth considering now.

comment:9 Changed 4 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to master. I think the appveyor thing is unrelated, but I'll keep an eye on it.

comment:10 Changed 2 months ago by nickm

Actual Points: .2
Note: See TracTickets for help on using tickets.