Opened 7 months ago

Closed 4 weeks ago

#28369 closed defect (fixed)

remove pingsender from Tor Browser

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-proxy-bypass, TorBrowserTeam201904R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In https://bugzilla.mozilla.org/show_bug.cgi?id=1310703 (for Firefox 54), Mozilla added a pingsender executable that uses libcurl to send telemetry info when a crash occurs. While we disable telemetry by pref, for defense-in-depth against a potential proxy bypass we should stop shipping the pingsender executable.

Child Tickets

Change History (10)

comment:1 Changed 6 months ago by gk

Keywords: TorBrowserTeam201811 added

comment:2 Changed 6 months ago by gk

Keywords: tbb-proxy-bypass added

comment:3 Changed 6 months ago by gk

Keywords: TorBrowserTeam201812 added; TorBrowserTeam201811 removed

Moving our tickets to December.

comment:4 Changed 4 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201812 removed

Moving tickets to Jan 2019.

comment:5 Changed 4 months ago by gk

Keywords: TorBrowserTeam201902 added; TorBrowserTeam201901 removed

Moving tickets to February.

comment:6 Changed 3 months ago by gk

Keywords: TorBrowserTeam201903 added; TorBrowserTeam201902 removed

Moving remaining tickets to March.

comment:7 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201903 removed

Moving tickets to April.

comment:8 Changed 6 weeks ago by acat

Patch here https://github.com/acatarineu/tor-browser/commit/28369.

Tested that it builds Linux, Windows, Mac without pingsender executable.

Do we run Firefox tests for tor-browser? If so, there are some tests for pingsender that I assume would fail, so in that case I would need to remove those too.

comment:9 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201904 removed
Status: newneeds_review

No, we don't need to take care of tests here as we are likely not upstreaming that particular patch.

comment:10 in reply to:  8 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to acat:

Patch here https://github.com/acatarineu/tor-browser/commit/28369.

Tested that it builds Linux, Windows, Mac without pingsender executable.

Looks good to me. Cherry-picked to tor-browser-60.6.1esr-8.5-1 (commit c1262822e77cf26780d240646bacd14a67e6c301).

Note: See TracTickets for help on using tickets.