Opened 2 years ago

Last modified 5 months ago

#28396 needs_review defect

Temporary gpg signature verification scripts are not removed

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/rbm Version:
Severity: Normal Keywords: TorBrowserTeam202006R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In order to verify gpg signature of git tags and commits, rbm is creating temporary scripts in the tmp directory, but those scripts are not removed.

Child Tickets

Change History (3)

comment:1 Changed 6 months ago by gaba

Owner: changed from boklm to tbb-team
Status: newassigned

Release all this tickets back into tbb-team.

comment:2 Changed 5 months ago by boklm

Keywords: TorBrowserTeam202006R added
Status: assignedneeds_review

There is a patch fixing that in branch bug_28396_v2:
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_28396_v2&id=30188a4ffe947fb728c86600b793df775cc171e7

The patch is fixing that by creating all temporary files inside rbm_tmp_dir instead of tmp_dir, which is removed automatically when rbm exits.

While doing that I also noticed an issue with urlget, which used tmp_dir, causing scripts using urlget to depend on the value of tmp_dir. For example this caused the filename of firefox-langpacks to change when we move the tor-browser-build directory. urlget is also used in projects/common/fetch-gradle-dependencies so we have the same issue with projects using this script. With this patch, the tor-browser filename is not changing anymore when we move the tor-browser-build directory.

comment:3 in reply to:  2 Changed 5 months ago by boklm

Replying to boklm:

There is a patch fixing that in branch bug_28396_v2:
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_28396_v2&id=30188a4ffe947fb728c86600b793df775cc171e7

Also, this branch is based on the patches for #33991 and #34320.

Note: See TracTickets for help on using tickets.