Opened 4 weeks ago

Closed 4 weeks ago

#28397 closed enhancement (implemented)

Please provide a method on descriptors to generate a @type annotation

Reported by: irl Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently when I download using the DescriptorDownloader I get objects that I can call get_bytes() on to dump out the content as it was downloaded to disk, but I'd like to also add the annotation for the type for when this is read back in.

Child Tickets

Change History (3)

comment:1 Changed 4 weeks ago by atagar

Thanks irl, interesting addition. Does this do the trick for ya?

https://gitweb.torproject.org/stem.git/commit/?id=1fa7518

comment:2 Changed 4 weeks ago by irl

Perfect. Hardcoding the 1.0 seemed like a bad thing, but then I looked at my code and realised this is what I'd done too, so actually this is fine for now.

Thanks!

comment:3 Changed 4 weeks ago by atagar

Resolution: implemented
Status: newclosed

My pleasure! Thanks for suggesting it.

Note: See TracTickets for help on using tickets.