Opened 4 weeks ago

Closed 4 weeks ago

#28413 closed defect (fixed)

FreeBSD build warning in aes_new_cipher()

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-crypto, 029-backport, 033-backport, 034-backport
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: dgoulet Sponsor:

Description

Our jenkins freebsd builders are trying again! And they are failing with:

18:20:41 ../tor/src/common/aes.c:107:14: error: variable 'c' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
18:20:41     default: tor_assert(0); // LCOV_EXCL_LINE
18:20:41              ^~~~~~~~~~~~~

Initializing c to NULL should solve this problem, which is IMO the compiler's fault.

Child Tickets

Change History (5)

comment:1 Changed 4 weeks ago by nickm

Status: assignedneeds_review

See branch bug28413_029 with PR at https://github.com/torproject/tor/pull/499

comment:2 Changed 4 weeks ago by nickm

Actual Points: 0

comment:3 Changed 4 weeks ago by dgoulet

Keywords: tor-crypto 029-backport 033-backport 034-backport added
Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

comment:4 Changed 4 weeks ago by nickm

merged!

comment:5 Changed 4 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.