Opened 2 months ago

Closed 4 days ago

#28416 closed defect (fixed)

The ns consensus isn't explicitly ns in the network-status-version line of flavored consensuses

Reported by: irl Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

Please review my pull request for torspec:

https://github.com/torproject/torspec/pull/45

tor does not generate ns consensuses that are explicitly labelled as ns
consensuses. This updates the spec to make the flavor portion optional,
and to allow the assumption to be made that if a flavor is omitted from
the "network-status-version" line then it is "ns".

One "flavour" was also turned into a "flavor" for consistency.

Child Tickets

Change History (6)

comment:1 Changed 2 months ago by irl

Status: newneeds_review

comment:2 Changed 2 months ago by teor

Milestone: Tor: 0.4.0.x-final

Spec tickets go in the latest Tor milestone, I think

comment:3 Changed 2 months ago by dgoulet

Keywords: tor-spec added; dir-spec removed

comment:4 Changed 2 months ago by dgoulet

Reviewer: mikeperry

comment:5 Changed 6 weeks ago by teor

Reviewer: mikeperryteor

Taking over reviews from Mike, because he's busy with WTF-PAD.

comment:6 Changed 4 days ago by nickm

Resolution: fixed
Reviewer: teornickm
Status: needs_reviewclosed

looks fine to me; merged

Note: See TracTickets for help on using tickets.