#28419 closed defect (fixed)

libtorrunner: memory leak in tor_runner error path

Reported by: merge Owned by:
Priority: Low Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: memleak, 034-backport?
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:


In case execv fails, libtorrunner's child() leaks string-memory.

Child Tickets

Attachments (1)

0001-libtorrunner-fix-memory-leak-in-child-error-path.patch (728 bytes) - added by merge 19 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 19 months ago by dgoulet

Keywords: memleak added
Milestone: Tor: unspecified
Status: newneeds_review
Version: Tor: unspecified

comment:2 Changed 19 months ago by nickm

Keywords: 034-backport? added
Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Reviewer: nickm

comment:3 Changed 19 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.3.x-final
Resolution: fixed
Status: needs_reviewclosed

This is worth doing, since it's nice to have a free for every allocation.

I've added a changes file (26fd7c1d9cdb7a3a4c379be7d309bd1b4c6bbaa4), and fixed a warning from "make check" (db3acb3aa398bda46435d94427967410da173222), then merged this to maint-0.3.3 and forward. Thanks!

Note: See TracTickets for help on using tickets.