Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#28451 closed enhancement (implemented)

2. make sbws round to 2 significant figures, as in proposal 276

Reported by: teor Owned by: teor
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: prop276, sbws-1.0-nice-closed-moved-20181128
Cc: pastly, juga, teor Actual Points:
Parent ID: #27689 Points:
Reviewer: Sponsor:

Description

The next step in implementing proposal 276 is to change the default rounding to 2 significant figures, from 3 significant figures.

Child Tickets

Change History (6)

comment:1 Changed 13 months ago by teor

Status: assignedneeds_review

See https://github.com/torproject/sbws/pull/287

We can merge this change in sbws 1.0, or we can wait for sbws 1.1.

When we merge this change, consensus diffs get 5%-10% smaller, so I think we should take it earlier.

But it is your decision, juga.

comment:2 Changed 13 months ago by juga

While there're bwauths using torflow, are the consensus diffs going to get smaller?

comment:3 in reply to:  2 Changed 13 months ago by teor

Replying to juga:

While there're bwauths using torflow, are the consensus diffs going to get smaller?

Yes.

There are 6 bwauths voting. The final bandwidth is the (low-)median of the votes. So each bwauth determines about 1/6 of the relay bandwidths. For every bwauth running sbws, 1/6 of the final bandwidths will be rounded, and more compressible.
https://gitweb.torproject.org/torspec.git/tree/proposals/276-lower-bw-granularity.txt#n43

comment:4 Changed 13 months ago by juga

Status: needs_reviewmerge_ready

lgtm, thanks!

comment:5 Changed 13 months ago by juga

Resolution: implemented
Status: merge_readyclosed

Merged

comment:6 Changed 13 months ago by teor

Keywords: sbws-1.0-nice-closed-moved-20181128 added
Milestone: sbws 1.0 (MVP nice)sbws: 1.0.x-final

Move all closed sbws 1.0 nice tickets to sbws 1.0.x-final

Note: See TracTickets for help on using tickets.