Opened 4 weeks ago

Closed 4 weeks ago

Last modified 42 hours ago

#28470 closed defect (fixed)

Add fetch gradle dependency script to common project

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-mobile, TBA-a2, TorBrowserTeam201811R
Cc: sisbell, gk, boklm Actual Points:
Parent ID: #26693 Points:
Reviewer: Sponsor: Sponsor8

Description


Child Tickets

Change History (6)

comment:1 Changed 4 weeks ago by sisbell

Cc: gk boklm added

comment:2 Changed 4 weeks ago by sisbell

Status: newneeds_review

Changes (android-1115)

  • Moved the fetch dependencies script to common and made it general for orbot and firefox

Unresolved: where should we put the how-to documentation for the script? In common as well?

comment:3 Changed 4 weeks ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201811 removed

comment:4 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, I chatted a bit with boklm and we think we should have it in common as well. I moved forward with a proposed patch (bug_28470 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_28470&id=1813bdb93cf73c20d90f689f00d436b7939dd2f0)) and boklm essentially ack'ed it (modulo a small typo). The result landed on master (commit 873289e271fb88c47e1c5738b66a37b723e74ee2).

comment:5 Changed 4 weeks ago by boklm

To make the file projects/common/how-to-create-gradle-dependencies-list.txt easier to find, I think we should add a comment at the top of each gradle-dependencies-list.txt file pointing to it.

comment:6 Changed 42 hours ago by gk

Sponsor: Sponsor8

Sponsor 8 work.

Note: See TracTickets for help on using tickets.