Opened 4 weeks ago

Closed 3 weeks ago

Last modified 2 weeks ago

#28472 closed defect (fixed)

Add Android Makefile Rules

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-mobile, TBA-a2, TorBrowserTeam201811R
Cc: sisbell, gk, boklm Actual Points:
Parent ID: #26693 Points:
Reviewer: Sponsor: Sponsor8

Description

Add rules for building tor browser on Android

Child Tickets

Change History (10)

comment:1 Changed 4 weeks ago by sisbell

Cc: gk boklm added

comment:2 Changed 4 weeks ago by sisbell

Changes (android-1115)

  • Added alpha target for android

comment:3 Changed 4 weeks ago by sisbell

Status: newneeds_review

comment:4 Changed 4 weeks ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201811 removed

comment:5 Changed 4 weeks ago by boklm

Keywords: TorBrowserTeam201811 added; TorBrowserTeam201811R removed
Status: needs_reviewneeds_revision

I think the commit should also add the following makefile rules:

  • release-android-armv7
  • nightly-android-armv7
  • alpha_nightly-android-armv7
  • testbuild-android-armv7

comment:6 Changed 3 weeks ago by sisbell

Status: needs_revisionneeds_review

Changes (android-1116)

  • Added release-android-armv7, nightly-android-armv7, alpha_nightly-android-armv7, testbuild-android-armv7

comment:7 Changed 3 weeks ago by sisbell

Sounds like we may need to change the output name of the apk based on the release target?

comment:8 in reply to:  7 Changed 3 weeks ago by gk

Replying to sisbell:

Sounds like we may need to change the output name of the apk based on the release target?

I think we are good with the patch as-is. All things that need changing should get done in the patch for #28144.

comment:9 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201811 removed
Resolution: fixed
Status: needs_reviewclosed

Applied the patch to master (commit 836a8b56606978fa7a140cfd1a9d9ddb6b2e41e2), thanks!

comment:10 Changed 2 weeks ago by pili

Sponsor: Sponsor8
Note: See TracTickets for help on using tickets.