Opened 4 weeks ago

Closed 3 weeks ago

Last modified 42 hours ago

#28483 closed defect (fixed)

Modify Android Toolchain API Version

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-mobile, TBA-a2, TorBrowserTeam201811R
Cc: sisbell, gk Actual Points:
Parent ID: #26693 Points:
Reviewer: Sponsor: Sponsor8

Description

Change toolchain api to 16 in android-toolchain project

Child Tickets

Change History (9)

comment:1 Changed 4 weeks ago by sisbell

Fixed in android-1116

comment:2 Changed 3 weeks ago by sisbell

Status: newneeds_review

comment:3 Changed 3 weeks ago by gk

Status: needs_reviewneeds_information

What is the Rust angle here? That is, why do we need to set the API to 16 for building Rust? Building Rust and running Tor Browser for Android with --api 26 is working fine for me.

Last edited 3 weeks ago by gk (previous) (diff)

comment:4 in reply to:  3 ; Changed 3 weeks ago by sisbell

Replying to gk:

What is the Rust angle here? That is, why do we need to set the API to 16 for building Rust? Building Rust and running Tor Browser for Android with --api 26 is working fine for me.

I would expect that it would work but I was thinking we should compile our rust libraries with the same version of the NDK as the rest of the firefox native code.

Rust is using --set=target.armv7-linux-androideabi.cc=$ANDROID_NDK_HOME/arm/bin/arm-linux-androideabi-gcc which is pointing to the location we created using with the make_standalone_toolchain script.

Or am I missing the question?

comment:5 in reply to:  4 Changed 3 weeks ago by gk

Replying to sisbell:

Replying to gk:

What is the Rust angle here? That is, why do we need to set the API to 16 for building Rust? Building Rust and running Tor Browser for Android with --api 26 is working fine for me.

I would expect that it would work but I was thinking we should compile our rust libraries with the same version of the NDK as the rest of the firefox native code.

Rust is using --set=target.armv7-linux-androideabi.cc=$ANDROID_NDK_HOME/arm/bin/arm-linux-androideabi-gcc which is pointing to the location we created using with the make_standalone_toolchain script.

Or am I missing the question?

I think you missed the question. :) Sure, we should build everything with the same NDK version if possible. But: switching from --api 26 to --api 16 is not because there is something wrong with Rust in particular (as your comment indicates) but because we want to use --api 16 for the whole project. Maybe instead of the comment you currently have we could write something like "API 16 is the minimum we currently support for Tor Browser on Android."

comment:6 Changed 3 weeks ago by sisbell

Changes (android-1120)

  • Updated comment

comment:7 Changed 3 weeks ago by sisbell

Status: needs_informationneeds_review

comment:8 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201811 removed
Resolution: fixed
Status: needs_reviewclosed

Looks good now, thanks! Applied to master (commit d66abd6cb81944bb24f9ec4255a5311bdebf58da).

comment:9 Changed 42 hours ago by gk

Sponsor: Sponsor8

Sponsor 8 work.

Note: See TracTickets for help on using tickets.