Modify Android Toolchain API Version
Change toolchain api to 16 in android-toolchain project
Activity
Replying to gk:
What is the Rust angle here? That is, why do we need to set the API to 16 for building Rust? Building Rust and running Tor Browser for Android with
--api 26is working fine for me.I would expect that it would work but I was thinking we should compile our rust libraries with the same version of the NDK as the rest of the firefox native code.
Rust is using --set=target.armv7-linux-androideabi.cc=$ANDROID_NDK_HOME/arm/bin/arm-linux-androideabi-gcc which is pointing to the location we created using with the make_standalone_toolchain script.
Or am I missing the question?
Replying to sisbell:
Replying to gk:
What is the Rust angle here? That is, why do we need to set the API to 16 for building Rust? Building Rust and running Tor Browser for Android with
--api 26is working fine for me.I would expect that it would work but I was thinking we should compile our rust libraries with the same version of the NDK as the rest of the firefox native code.
Rust is using --set=target.armv7-linux-androideabi.cc=$ANDROID_NDK_HOME/arm/bin/arm-linux-androideabi-gcc which is pointing to the location we created using with the make_standalone_toolchain script.
Or am I missing the question?
I think you missed the question. :) Sure, we should build everything with the same NDK version if possible. But: switching from
--api 26to--api 16is not because there is something wrong with Rust in particular (as your comment indicates) but because we want to use--api 16for the whole project. Maybe instead of the comment you currently have we could write something like "API 16 is the minimum we currently support for Tor Browser on Android."