Opened 2 months ago

Closed 2 months ago

#28485 closed defect (fixed)

Link failure for tor-print-ed-signing-cert.exe on Windows

Reported by: ahf Owned by: ahf
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Major Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Currently Tor fails to build on Windows because of:

  CCLD     src/tools/tor-print-ed-signing-cert.exe
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x100d): undefined reference to `_imp__GetDeviceCaps@8'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x103b): undefined reference to `_imp__CreateCompatibleBitmap@12'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x105d): undefined reference to `_imp__GetObjectA@12'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x113d): undefined reference to `_imp__GetDIBits@28'
/usr/bin/i686-w64-mingw32-ld: /home/user/src/github.com/ahf/tor-win32/prefix/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x11a1): undefined reference to `_imp__DeleteObject@4'

This is because we are missing to include the library from @TOR_LIB_GDI@. Patch coming up.

Child Tickets

Change History (5)

comment:1 Changed 2 months ago by ahf

Status: assignedneeds_review

comment:2 Changed 2 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.5.x-final

comment:3 Changed 2 months ago by dgoulet

Reviewer: ahf

comment:4 Changed 2 months ago by dgoulet

Reviewer: ahfdgoulet
Status: needs_reviewmerge_ready

I can't test this on Windows but this seems trivial fix to me.

comment:5 Changed 2 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

cherry-picked to maint-0.3.5 and then merged forward.

Note: See TracTickets for help on using tickets.