Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#28508 closed defect (fixed)

Stem not checking for '' correctly

Reported by: opara Owned by: atagar
Priority: Low Milestone:
Component: Archived/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When "contoller.get_microdescriptors()" is called, it checks to see if the file "cached-microdescs" exists before creating a "stem.descriptor.reader.DescriptorReader" object. The problem is that "cached-microdescs" may not exist, but "" does.

A simple fix for this is to modify stem/ (as of commit 73e5bd3e4f5) from:

elif not os.path.exists(cached_descriptor_path):


elif not os.path.exists(cached_descriptor_path) and not os.path.exists(cached_descriptor_path+'.new'):

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by opara

Component: - Select a componentCore Tor/Stem
Owner: set to atagar

comment:2 Changed 2 years ago by atagar

Resolution: fixed
Status: newclosed

Hi opara, sorry about the delay! Fix pushed. It's a tad more than that (the above fix corrects the check, but didn't make us read from the Made some other improvements to this while we were at it.

Thanks for reporting this!

comment:3 Changed 2 years ago by opara

Thanks! Works great now.

Note: See TracTickets for help on using tickets.