Opened 7 months ago

Closed 7 months ago

Last modified 6 months ago

#28540 closed defect (fixed)

12/11 release Banner text

Reported by: sstevenson Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-fundraising, ux-team, TorBrowserTeam201812R
Cc: sstevenson, antonela, tbb-team Actual Points:
Parent ID: #23925 Points:
Reviewer: Sponsor:

Description (last modified by isabela)

Please create the following 6 banners where:

[Line 1, non-variable] Tor: Strength in Numbers

[Line 2, variable]

  1. Keep Tor strong. Give today, and Mozilla will match your donation. https://marvelapp.com/a131e34/screen/48876408
  1. Mozilla is matching every donation until 2019. Give now, and your gift becomes twice as strong.

please notice that the 'Give today, and Mozilla will match your donation" phrase will change here and be: "Give now, and your gift becomes twice as strong."

  1. Support internet freedom. Give today, and Mozilla will match your donation.
  1. Defend the open web. Give today, and Mozilla will match your donation.
  1. Support privacy and freedom online. Give today, and Mozilla will match your donation.
  1. We need your support. Every dollar counts. Give today, and Mozilla will match your donation.

[Button]:
“Count me in.” To be used in English.

“Donate now.” To be used for all other languages.

Child Tickets

Change History (11)

comment:1 Changed 7 months ago by isabela

Cc: antonela tbb-team added; sstevenson@… removed
Description: modified (diff)

comment:2 Changed 7 months ago by isabela

Let us know if you have any question on the rotation, frequency an user would see it and any other behavior of the banner.

comment:3 in reply to:  2 ; Changed 7 months ago by gk

Replying to isabela:

Let us know if you have any question on the rotation, frequency an user would see it and any other behavior of the banner.

Who is "you" here? :) I assume we keep the mechanics of our banners and just update the text in this bug as the title indicates? Or do we need to use new images etc. and if so, where are they?

comment:4 in reply to:  3 Changed 7 months ago by isabela

Replying to gk:

Replying to isabela:

Let us know if you have any question on the rotation, frequency an user would see it and any other behavior of the banner.

Who is "you" here? :) I assume we keep the mechanics of our banners and just update the text in this bug as the title indicates? Or do we need to use new images etc. and if so, where are they?

You = tbb-team :)
No new images, I am not familiar with the mechanics now but if they are:

  1. an user only gets to see 2 versions out of the 6
  2. if the user sees version 1 and either: click on donate or click on dismiss (x) they don't get to see version 2

then yes, keep the same mechanics.

comment:5 Changed 7 months ago by sstevenson

Isa - the mechanics last time around was that each user saw all six banners - each two times. They stopped seeing the banners completely if they click on one. My understanding was that we'd do that again.

comment:6 Changed 7 months ago by arthuredelstein

Status: newneeds_review

Here's a patch for the text, for review. I am adding the new strings and leaving in the old strings for now.

https://github.com/arthuredelstein/torbutton/commit/28540

(I will post a follow-up patch for modifying the banner code to use the new and retained strings only.)

I discussed with Sarah and we decided to leave out the "every dollar counts" phrase because it doesn't work well for many locales. That means we can use the existing "We need your support" string.

Last edited 7 months ago by arthuredelstein (previous) (diff)

comment:7 Changed 7 months ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201810R removed

comment:8 in reply to:  6 Changed 7 months ago by gk

Keywords: TorBrowserTeam201811 added; TorBrowserTeam201811R removed
Priority: MediumVery High
Status: needs_reviewnew

Replying to arthuredelstein:

Here's a patch for the text, for review. I am adding the new strings and leaving in the old strings for now.

https://github.com/arthuredelstein/torbutton/commit/28540

That's commit 1503b5e151cd8bb528f143f5fdf4513791d3f10f on Torbutton's master branch now.

comment:9 Changed 7 months ago by arthuredelstein

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201811 removed
Status: newneeds_review

Here's the patch to actually use the new strings. It also effectively restarts the banner countdown. I have tested this on desktop but not mobile.

https://github.com/arthuredelstein/torbutton/commit/28540+1

comment:10 Changed 7 months ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201811R removed

Move review tickets to Decemeber.

comment:11 Changed 7 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Cherry-picked to master (commit 4ad39b362dd7692b5e24841c616f63a5ca2bc67a).

Edit: This got applied to maint-2.0 as well as commit 207e78133408f4839f81322a5839163cb90a7223.

Last edited 6 months ago by gk (previous) (diff)
Note: See TracTickets for help on using tickets.