Opened 9 months ago

Closed 7 months ago

Last modified 7 months ago

#28546 closed project (fixed)

Rebrand Tor Browser's Window's Installer

Reported by: pospeselr Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201901R
Cc: tbb-team, antonela Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The windows NSIS installer could use some rebranding as well!

TODO per build (stable, alpha, nightly):

  • icon
  • default install path and shortcut name (to allow side-by-side installation)
    • release-$OS-$ARCH -> 'Tor Browser'
    • alpha-$OS-$ARCH -> 'Tor Browser Alpha'
    • nightly-$OS-$ARCH -> 'Tor Browser Nightly'

Child Tickets

Attachments (4)

28546_00.patch (231.5 KB) - added by pospeselr 9 months ago.
nsis-branding.png (53.0 KB) - added by pospeselr 9 months ago.
28546_01.patch (202.4 KB) - added by pospeselr 8 months ago.
28546_02.patch (195.5 KB) - added by pospeselr 7 months ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 months ago by pospeselr

Summary: Rebrand Tor Browser's InstallerRebrand Tor Browser's Window's Installer

Changed 9 months ago by pospeselr

Attachment: 28546_00.patch added

Changed 9 months ago by pospeselr

Attachment: nsis-branding.png added

comment:2 Changed 9 months ago by pospeselr

Cc: antonela added
Keywords: TorBrowserTeam201811R added
Status: assignedneeds_review

These patches update the branding for tor-browser's windows NSIS installer. The new channel specific icons are used and the default install path and shortcuts include the channel name to allow side-by-side installations. The shortcut name has also been changed from 'Start Tor Browser' to:

  • release -> 'Tor Browser.lnk'
  • nightly -> 'Tor Browser Nightly.lnk'
  • alpha -> 'Tor Browser Alpha.lnk'

https://trac.torproject.org/projects/tor/raw-attachment/ticket/28546/nsis-branding.png


tbb-windows-installer patch (I don't seem to have a tbb-windows-installer gitweb):

https://trac.torproject.org/projects/tor/raw-attachment/ticket/28546/28546_02.patch

tor-browser-build change:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_28546

EDIT: Updated the icons used with less-squashed versions from #25702

Last edited 7 months ago by pospeselr (previous) (diff)

comment:3 Changed 9 months ago by antonela

\o/ looks great! thanks pospeselr!

comment:4 Changed 9 months ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201811R removed

Move review tickets to Decemeber.

comment:5 Changed 8 months ago by gk

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201812R removed

Moving review tickets to 2019.

Changed 8 months ago by pospeselr

Attachment: 28546_01.patch added

Changed 7 months ago by pospeselr

Attachment: 28546_02.patch added

comment:6 Changed 7 months ago by gk

Parent ID: #25702

comment:7 Changed 7 months ago by boklm

I tested this patch with release and nightly builds, and it looks good to me.

I opened a pull request to merge the patch to upstream git repo:
https://github.com/moba/tbb-windows-installer/pull/4

comment:8 in reply to:  2 Changed 7 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to pospeselr:

tor-browser-build change:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_28546

I cherry-picked this commit, and added the tbb-windows-installer version change, and pushed this as commit 031ecd732636c627ea3b6343869d96ccbf3d2df0.

comment:9 Changed 7 months ago by gk

FWIW, we needed to back this out for the 8.5a7 release due to #29185. No reopening necessary as we deal with re-landing the patch there as well.

Note: See TracTickets for help on using tickets.