Rebrand Tor Browser's Window's Installer

The windows NSIS installer could use some rebranding as well!

TODO per build (stable, alpha, nightly):

• icon
• default install path and shortcut name (to allow side-by-side installation)
• release-
  $OS-$
  ARCH -> 'Tor Browser'
• alpha-
  $OS-$
  ARCH -> 'Tor Browser Alpha'
• nightly-
  $OS-$
  ARCH -> 'Tor Browser Nightly'

added TorBrowserTeam201901R component::applications/tor browser owner::pospeselr priority::medium resolution::fixed severity::normal status::closed type::project labels

Trac:
Summary: Rebrand Tor Browser's Installer to Rebrand Tor Browser's Window's Installer

Trac:
28546_00.patch

Trac:

These patches update the branding for tor-browser's windows NSIS installer. The new channel specific icons are used and the default install path and shortcuts include the channel name to allow side-by-side installations. The shortcut name has also been changed from 'Start Tor Browser' to:

• release -> 'Tor Browser.lnk'
• nightly -> 'Tor Browser Nightly.lnk'
• alpha -> 'Tor Browser Alpha.lnk'

---

tbb-windows-installer patch (I don't seem to have a tbb-windows-installer gitweb): https://trac.torproject.org/projects/tor/raw-attachment/ticket/28546/28546_02.patch

tor-browser-build change: https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_28546

EDIT: Updated the icons used with less-squashed versions from #25702 (moved)

Trac:
Status: assigned to needs_review
Cc: tbb-team to tbb-team, antonela
Keywords: N/A deleted, TorBrowserTeam201811R added

\o/ looks great! thanks pospeselr!

Move review tickets to Decemeber.

Trac:
Keywords: TorBrowserTeam201811R deleted, TorBrowserTeam201812R added

Moving review tickets to 2019.

Trac:
Keywords: TorBrowserTeam201812R deleted, TorBrowserTeam201901R added

Trac:
28546_01.patch

Trac:
28546_02.patch

Trac:
Parent: #25702 (moved) to N/A

I tested this patch with release and nightly builds, and it looks good to me.

I opened a pull request to merge the patch to upstream git repo: https://github.com/moba/tbb-windows-installer/pull/4

Replying to pospeselr:

tor-browser-build change: https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_28546

I cherry-picked this commit, and added the tbb-windows-installer version change, and pushed this as commit 031ecd732636c627ea3b6343869d96ccbf3d2df0.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

FWIW, we needed to back this out for the 8.5a7 release due to #29185 (moved). No reopening necessary as we deal with re-landing the patch there as well.

closed

mentioned in issue #28809 (moved)

mentioned in issue #28810 (moved)

mentioned in issue #29185 (moved)

moved to tpo/applications/tor-browser#28546 (closed)

mentioned in issue tpo/applications/tor-browser#28809 (moved)

mentioned in issue tpo/applications/tor-browser#28810 (closed)

mentioned in issue tpo/applications/tor-browser-build#29185 (closed)

mentioned in issue tpo/applications/tor-browser-build#40569 (closed)